starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #550] [MERGED] Improve Code Quality 3 #1089

New Issue
Open
opened 2026-01-29 22:18:57 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:18:57 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/550
Author: @iamcarbon
Created: 11/18/2020
Status: ✅ Merged
Merged: 11/18/2020
Merged by: @adamhathcock

Base: master ← Head: cq

📝 Commits (10+)

  • 9576867 Enable C# 9
  • c61ee0c Update deps
  • dd48e42 Simplify .NET framework code exclusions, bump min .NET framework version to 4.6.1
  • b0101f2 Eliminate culture specific StartsWith comparisions
  • 8090d26 Add polyfills for string.EndWith(char) && string.Contains(char)
  • d8804ae Improve conditional logic to prepare to add .NETCOREAPP target
  • fa241bb Inline variable declarations
  • 0129a93 Remove NETSTANDARD1_3 symbol
  • e47e1d2 Format AesDecoderStream
  • a1d45b4 Format ArchiveFactory

📊 Changes

21 files changed (+143 additions, -175 deletions)

View changed files

📝 src/SharpCompress/Archives/AbstractArchive.cs (+7 -7)
📝 src/SharpCompress/Archives/AbstractWritableArchive.cs (+2 -3)
📝 src/SharpCompress/Archives/ArchiveFactory.cs (+37 -52)
📝 src/SharpCompress/Archives/Rar/RarArchiveVolumeFactory.cs (+3 -5)
📝 src/SharpCompress/Common/ArchiveEncoding.cs (+1 -1)
📝 src/SharpCompress/Common/ExtractionMethods.cs (+4 -6)
📝 src/SharpCompress/Common/Rar/Headers/NewSubHeaderType.cs (+13 -19)
📝 src/SharpCompress/Common/SevenZip/ArchiveReader.cs (+1 -1)
📝 src/SharpCompress/Common/SevenZip/CMethodId.cs (+1 -1)
📝 src/SharpCompress/Common/Zip/Headers/ZipFileEntry.cs (+2 -2)
📝 src/SharpCompress/Compressors/BZip2/BZip2Stream.cs (+1 -1)
📝 src/SharpCompress/Compressors/Deflate/GZipStream.cs (+5 -5)
📝 src/SharpCompress/Compressors/LZMA/AesDecoderStream.cs (+36 -62)
📝 src/SharpCompress/Compressors/LZMA/LZipStream.cs (+1 -1)
📝 src/SharpCompress/Compressors/Xz/Filters/BlockFilter.cs (+1 -1)
📝 src/SharpCompress/Crypto/Crc32Stream.cs (+1 -1)
📝 src/SharpCompress/IO/NonDisposingStream.cs (+1 -1)
📝 src/SharpCompress/Polyfills/StreamExtensions.cs (+1 -1)
➕ src/SharpCompress/Polyfills/StringExtensions.cs (+19 -0)
📝 src/SharpCompress/SharpCompress.csproj (+5 -4)

...and 1 more files

📄 Description

A handful of tiny cleanups and precursor work to introduce hardware accelerated checksum algorithms.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/550 **Author:** [@iamcarbon](https://github.com/iamcarbon) **Created:** 11/18/2020 **Status:** ✅ Merged **Merged:** 11/18/2020 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `cq` --- ### 📝 Commits (10+) - [`9576867`](https://github.com/adamhathcock/sharpcompress/commit/9576867c346184388fdd22f3929c4bb19d7ed4fb) Enable C# 9 - [`c61ee0c`](https://github.com/adamhathcock/sharpcompress/commit/c61ee0c24fc882d443eb88299d33e7865e7801b7) Update deps - [`dd48e42`](https://github.com/adamhathcock/sharpcompress/commit/dd48e4299a00adfb711e67a8cc3247546c6432b1) Simplify .NET framework code exclusions, bump min .NET framework version to 4.6.1 - [`b0101f2`](https://github.com/adamhathcock/sharpcompress/commit/b0101f20c5a866352103753b56520e47dface377) Eliminate culture specific StartsWith comparisions - [`8090d26`](https://github.com/adamhathcock/sharpcompress/commit/8090d269e74e6da02909f23865b73879f632144b) Add polyfills for string.EndWith(char) && string.Contains(char) - [`d8804ae`](https://github.com/adamhathcock/sharpcompress/commit/d8804ae1080f91859e66dcaca5760e2d9c9b7e3a) Improve conditional logic to prepare to add .NETCOREAPP target - [`fa241bb`](https://github.com/adamhathcock/sharpcompress/commit/fa241bb0d778247273dfe4eaf11de20ebfd57f4f) Inline variable declarations - [`0129a93`](https://github.com/adamhathcock/sharpcompress/commit/0129a933dffd4ee96821c5d12fc44ada18472203) Remove NETSTANDARD1_3 symbol - [`e47e1d2`](https://github.com/adamhathcock/sharpcompress/commit/e47e1d220a524f861dc9e8efe9231348ce21e702) Format AesDecoderStream - [`a1d45b4`](https://github.com/adamhathcock/sharpcompress/commit/a1d45b44cd9d88e30f161a2ac32427e9578a27e6) Format ArchiveFactory ### 📊 Changes **21 files changed** (+143 additions, -175 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Archives/AbstractArchive.cs` (+7 -7) 📝 `src/SharpCompress/Archives/AbstractWritableArchive.cs` (+2 -3) 📝 `src/SharpCompress/Archives/ArchiveFactory.cs` (+37 -52) 📝 `src/SharpCompress/Archives/Rar/RarArchiveVolumeFactory.cs` (+3 -5) 📝 `src/SharpCompress/Common/ArchiveEncoding.cs` (+1 -1) 📝 `src/SharpCompress/Common/ExtractionMethods.cs` (+4 -6) 📝 `src/SharpCompress/Common/Rar/Headers/NewSubHeaderType.cs` (+13 -19) 📝 `src/SharpCompress/Common/SevenZip/ArchiveReader.cs` (+1 -1) 📝 `src/SharpCompress/Common/SevenZip/CMethodId.cs` (+1 -1) 📝 `src/SharpCompress/Common/Zip/Headers/ZipFileEntry.cs` (+2 -2) 📝 `src/SharpCompress/Compressors/BZip2/BZip2Stream.cs` (+1 -1) 📝 `src/SharpCompress/Compressors/Deflate/GZipStream.cs` (+5 -5) 📝 `src/SharpCompress/Compressors/LZMA/AesDecoderStream.cs` (+36 -62) 📝 `src/SharpCompress/Compressors/LZMA/LZipStream.cs` (+1 -1) 📝 `src/SharpCompress/Compressors/Xz/Filters/BlockFilter.cs` (+1 -1) 📝 `src/SharpCompress/Crypto/Crc32Stream.cs` (+1 -1) 📝 `src/SharpCompress/IO/NonDisposingStream.cs` (+1 -1) 📝 `src/SharpCompress/Polyfills/StreamExtensions.cs` (+1 -1) ➕ `src/SharpCompress/Polyfills/StringExtensions.cs` (+19 -0) 📝 `src/SharpCompress/SharpCompress.csproj` (+5 -4) _...and 1 more files_ </details> ### 📄 Description A handful of tiny cleanups and precursor work to introduce hardware accelerated checksum algorithms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:18:57 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1089
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?