starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-10 05:31:29 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #579] [MERGED] Do not place extension classes in common namespace #1113

New Issue
Open
opened 2026-01-29 22:19:03 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:19:03 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/579
Author: @Looooong
Created: 3/18/2021
Status: ✅ Merged
Merged: 3/18/2021
Merged by: @adamhathcock

Base: master ← Head: fix/do-not-place-extention-classes-in-common-namespace

📝 Commits (1)

  • 237ff9f Do not place extension classes in common namespace

📊 Changes

2 files changed (+10 additions, -8 deletions)

View changed files

📝 src/SharpCompress/Polyfills/StreamExtensions.cs (+6 -4)
📝 src/SharpCompress/Polyfills/StringExtensions.cs (+4 -4)

📄 Description

Do not place extension classes in common namespace, as the extension methods might conflict with the same counterpart (same name, same signature) from another separated namespace.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/579 **Author:** [@Looooong](https://github.com/Looooong) **Created:** 3/18/2021 **Status:** ✅ Merged **Merged:** 3/18/2021 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `fix/do-not-place-extention-classes-in-common-namespace` --- ### 📝 Commits (1) - [`237ff9f`](https://github.com/adamhathcock/sharpcompress/commit/237ff9f055be7834eb598e37236030f9c9434fff) Do not place extension classes in common namespace ### 📊 Changes **2 files changed** (+10 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Polyfills/StreamExtensions.cs` (+6 -4) 📝 `src/SharpCompress/Polyfills/StringExtensions.cs` (+4 -4) </details> ### 📄 Description Do not place extension classes in common namespace, as the extension methods might conflict with the same counterpart (same name, same signature) from another separated namespace. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:19:03 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1113
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?