starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #601] [MERGED] Write ZIP64 End of Central Directory only if needed. #1120

New Issue
Open
opened 2026-01-29 22:19:05 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:19:05 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/601
Author: @salvois
Created: 5/23/2021
Status: ✅ Merged
Merged: 6/4/2021
Merged by: @adamhathcock

Base: master ← Head: master

📝 Commits (2)

  • ad6d0d9 Write ZIP64 End of Central Directory only if needed.
  • c012db0 Merge branch 'master' into master

📊 Changes

1 file changed (+3 additions, -4 deletions)

View changed files

📝 src/SharpCompress/Writers/Zip/ZipWriter.cs (+3 -4)

📄 Description

Both Excel and LibreOffice fail to open an XLSX file compressed with SharpCompress when using ZIP64 (Excel is able to repair it, LibreOffice refuses it altogether).

Avoiding the ZIP64 End of Central Directory record when values are representable by the non-ZIP64 End of Central Directory record solves the issue.

This seems to be supported by the ZIP file format specification: "If one of the fields in the end of central directory record is too small to hold required data, the field SHOULD be set to -1 (0xFFFF or 0xFFFFFFFF) and the ZIP64 format record SHOULD be created." (https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT version 6.3.9, paragraph 4.4.1.4).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/601 **Author:** [@salvois](https://github.com/salvois) **Created:** 5/23/2021 **Status:** ✅ Merged **Merged:** 6/4/2021 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`ad6d0d9`](https://github.com/adamhathcock/sharpcompress/commit/ad6d0d9ae89dabf452ec52d115af769adea1b04d) Write ZIP64 End of Central Directory only if needed. - [`c012db0`](https://github.com/adamhathcock/sharpcompress/commit/c012db07760e6019413fcbf0101a062fce3a2c77) Merge branch 'master' into master ### 📊 Changes **1 file changed** (+3 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Writers/Zip/ZipWriter.cs` (+3 -4) </details> ### 📄 Description Both Excel and LibreOffice fail to open an XLSX file compressed with SharpCompress when using ZIP64 (Excel is able to repair it, LibreOffice refuses it altogether). Avoiding the ZIP64 End of Central Directory record when values are representable by the non-ZIP64 End of Central Directory record solves the issue. This seems to be supported by the ZIP file format specification: "If one of the fields in the end of central directory record is too small to hold required data, the field SHOULD be set to -1 (0xFFFF or 0xFFFFFFFF) and the ZIP64 format record SHOULD be created." (https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT version 6.3.9, paragraph 4.4.1.4). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:19:05 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1120
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?