starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-11 05:24:56 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #672] [MERGED] Corrected skip-marker on skip of uncompressed ZIP file with missing size informations. #1153

New Issue
Closed
opened 2026-01-29 22:19:14 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:19:14 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/672
Author: @MartinDemberger
Created: 6/15/2022
Status: ✅ Merged
Merged: 6/20/2022
Merged by: @adamhathcock

Base: master ← Head: Task_477

📝 Commits (3)

  • 8b55cce Better handling of uncompressed zip files.
  • ece7cbf Set skip-marker when stream is skipped
  • 62c94a1 Merge branch 'master' into Task_477

📊 Changes

6 files changed (+54 additions, -27 deletions)

View changed files

📝 src/SharpCompress/IO/RewindableStream.cs (+6 -4)
📝 src/SharpCompress/IO/SourceStream.cs (+2 -1)
📝 src/SharpCompress/Readers/AbstractReader.cs (+5 -4)
📝 tests/SharpCompress.Test/ArchiveTests.cs (+29 -18)
📝 tests/SharpCompress.Test/Zip/ZipArchiveTests.cs (+12 -0)
➕ tests/TestArchives/Archives/Zip.uncompressed.zip (+0 -0)

📄 Description

I did a first try to fix this issue. I'm not sure if my fix is correct. This fixes #477

My test is not working now because there is a EndOfStreamException thrown which I don't know how to avoid or if this is correct.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/672 **Author:** [@MartinDemberger](https://github.com/MartinDemberger) **Created:** 6/15/2022 **Status:** ✅ Merged **Merged:** 6/20/2022 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `Task_477` --- ### 📝 Commits (3) - [`8b55cce`](https://github.com/adamhathcock/sharpcompress/commit/8b55cce39a5e1110283e1110e2616348b2e74dfd) Better handling of uncompressed zip files. - [`ece7cbf`](https://github.com/adamhathcock/sharpcompress/commit/ece7cbfec3297b6cb0edbba195aac7e49a6179ad) Set skip-marker when stream is skipped - [`62c94a1`](https://github.com/adamhathcock/sharpcompress/commit/62c94a178cc4853a592e497cfde62c9f02b2ff74) Merge branch 'master' into Task_477 ### 📊 Changes **6 files changed** (+54 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/IO/RewindableStream.cs` (+6 -4) 📝 `src/SharpCompress/IO/SourceStream.cs` (+2 -1) 📝 `src/SharpCompress/Readers/AbstractReader.cs` (+5 -4) 📝 `tests/SharpCompress.Test/ArchiveTests.cs` (+29 -18) 📝 `tests/SharpCompress.Test/Zip/ZipArchiveTests.cs` (+12 -0) ➕ `tests/TestArchives/Archives/Zip.uncompressed.zip` (+0 -0) </details> ### 📄 Description I did a first try to fix this issue. I'm not sure if my fix is correct. This fixes #477 My test is not working now because there is a `EndOfStreamException` thrown which I don't know how to avoid or if this is correct. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:19:14 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1153
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?