starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-09 21:24:08 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #671] Introduced IArchiveFactory #1155

New Issue
Open
opened 2026-01-29 22:19:15 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:19:15 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/adamhathcock/sharpcompress/pull/671

State: closed
Merged: Yes

As agreed in #670 , I've introduced the IArchiveFactory interface, with the bare minimum methods required to keep all the funcionality, and the factory implementations for each archive type.

Also, added the RegisterFactory method in ArchiveFactory and adjusted the Open method to use the registered factories instead of the fixed list.

remaining issues:

Not sure to which factory should I assign some extensions lik .LZ

In ArchiveFactory there's some more Open methods that still use the fixed list, I guess they should be redirected to the Open method that uses the factory collection.

**Original Pull Request:** https://github.com/adamhathcock/sharpcompress/pull/671 **State:** closed **Merged:** Yes --- As agreed in #670 , I've introduced the `IArchiveFactory` interface, with the bare minimum methods required to keep all the funcionality, and the factory implementations for each archive type. Also, added the `RegisterFactory` method in `ArchiveFactory` and adjusted the `Open` method to use the registered factories instead of the fixed list. remaining issues: Not sure to which factory should I assign some extensions lik .LZ In ArchiveFactory there's some more Open methods that still use the fixed list, I guess they should be redirected to the Open method that uses the factory collection.
claunia added the pull-request label 2026-01-29 22:19:15 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1155
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?