starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-09 21:24:08 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #673] [MERGED] Feature/malformed zip file generated #1156

New Issue
Open
opened 2026-01-29 22:19:15 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:19:15 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/673
Author: @Erior
Created: 6/17/2022
Status: ✅ Merged
Merged: 6/20/2022
Merged by: @adamhathcock

Base: master ← Head: feature/Malformed-zip-file-generated

📝 Commits (2)

  • b6c4e28 Generated test case, however, don't see any problems
  • a00075e Wrong flags set, we do not expose this in the interface

📊 Changes

2 files changed (+20 additions, -6 deletions)

View changed files

📝 src/SharpCompress/Writers/Zip/ZipCentralDirectoryEntry.cs (+19 -5)
📝 tests/SharpCompress.Test/Zip/ZipWriterTests.cs (+1 -1)

📄 Description

This is connected to issue #666
We are setting wrong flags in the zip directory headers, I am unable to create a test case since we don't expose them, might be the next step.
Would then as an example allow setting "read-only" on a file if an extractor honers it.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/673 **Author:** [@Erior](https://github.com/Erior) **Created:** 6/17/2022 **Status:** ✅ Merged **Merged:** 6/20/2022 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `feature/Malformed-zip-file-generated` --- ### 📝 Commits (2) - [`b6c4e28`](https://github.com/adamhathcock/sharpcompress/commit/b6c4e28b4d393f08970919047e6ed8c5bff7054e) Generated test case, however, don't see any problems - [`a00075e`](https://github.com/adamhathcock/sharpcompress/commit/a00075ee0d3a712c4aa4cdb44c7a4f19eb7f8b6a) Wrong flags set, we do not expose this in the interface ### 📊 Changes **2 files changed** (+20 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Writers/Zip/ZipCentralDirectoryEntry.cs` (+19 -5) 📝 `tests/SharpCompress.Test/Zip/ZipWriterTests.cs` (+1 -1) </details> ### 📄 Description This is connected to issue #666 We are setting wrong flags in the zip directory headers, I am unable to create a test case since we don't expose them, might be the next step. Would then as an example allow setting "read-only" on a file if an extractor honers it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:19:15 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1156
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?