starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-10 13:39:12 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #674] [MERGED] Suppress nested NonDisposingStream #1157

New Issue
Closed
opened 2026-01-29 22:19:15 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:19:15 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/674
Author: @MartinDemberger
Created: 6/19/2022
Status: ✅ Merged
Merged: 6/20/2022
Merged by: @adamhathcock

Base: master ← Head: DeduplicateNonDisposing

📝 Commits (2)

  • 35336a0 Suppress nested NonDisposingStream
  • cd3114d Merge branch 'master' into DeduplicateNonDisposing

📊 Changes

19 files changed (+54 additions, -45 deletions)

View changed files

📝 src/SharpCompress/Archives/GZip/GZipWritableArchiveEntry.cs (+3 -3)
📝 src/SharpCompress/Archives/Tar/TarWritableArchiveEntry.cs (+3 -3)
📝 src/SharpCompress/Archives/Zip/ZipWritableArchiveEntry.cs (+3 -3)
📝 src/SharpCompress/Common/Volume.cs (+3 -3)
📝 src/SharpCompress/Common/Zip/StreamingZipFilePart.cs (+3 -3)
📝 src/SharpCompress/Common/Zip/ZipFilePart.cs (+3 -3)
📝 src/SharpCompress/Compressors/Xz/XZFooter.cs (+2 -2)
📝 src/SharpCompress/Compressors/Xz/XZHeader.cs (+2 -2)
📝 src/SharpCompress/Compressors/Xz/XZIndex.cs (+2 -2)
📝 src/SharpCompress/IO/NonDisposingStream.cs (+11 -2)
📝 src/SharpCompress/Readers/ReaderFactory.cs (+3 -3)
📝 src/SharpCompress/Writers/GZip/GZipWriter.cs (+3 -3)
📝 src/SharpCompress/Writers/Tar/TarWriter.cs (+2 -2)
📝 src/SharpCompress/Writers/Zip/ZipWriter.cs (+2 -2)
📝 tests/SharpCompress.Test/ArchiveTests.cs (+2 -2)
📝 tests/SharpCompress.Test/ReaderTests.cs (+2 -2)
📝 tests/SharpCompress.Test/Streams/ZlibBaseStreamTests.cs (+2 -2)
📝 tests/SharpCompress.Test/WriterTests.cs (+2 -2)
📝 tests/SharpCompress.Test/Zip/ZipReaderTests.cs (+1 -1)

📄 Description

Suppresses the creation of a NonDisposingStream which wrappes another NonDisposingStream with same settings

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/674 **Author:** [@MartinDemberger](https://github.com/MartinDemberger) **Created:** 6/19/2022 **Status:** ✅ Merged **Merged:** 6/20/2022 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `DeduplicateNonDisposing` --- ### 📝 Commits (2) - [`35336a0`](https://github.com/adamhathcock/sharpcompress/commit/35336a0827a77417ec52f9a650302c95181b89b8) Suppress nested NonDisposingStream - [`cd3114d`](https://github.com/adamhathcock/sharpcompress/commit/cd3114d39ef05fa6b3151f4d14196f0d7f26ebdf) Merge branch 'master' into DeduplicateNonDisposing ### 📊 Changes **19 files changed** (+54 additions, -45 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Archives/GZip/GZipWritableArchiveEntry.cs` (+3 -3) 📝 `src/SharpCompress/Archives/Tar/TarWritableArchiveEntry.cs` (+3 -3) 📝 `src/SharpCompress/Archives/Zip/ZipWritableArchiveEntry.cs` (+3 -3) 📝 `src/SharpCompress/Common/Volume.cs` (+3 -3) 📝 `src/SharpCompress/Common/Zip/StreamingZipFilePart.cs` (+3 -3) 📝 `src/SharpCompress/Common/Zip/ZipFilePart.cs` (+3 -3) 📝 `src/SharpCompress/Compressors/Xz/XZFooter.cs` (+2 -2) 📝 `src/SharpCompress/Compressors/Xz/XZHeader.cs` (+2 -2) 📝 `src/SharpCompress/Compressors/Xz/XZIndex.cs` (+2 -2) 📝 `src/SharpCompress/IO/NonDisposingStream.cs` (+11 -2) 📝 `src/SharpCompress/Readers/ReaderFactory.cs` (+3 -3) 📝 `src/SharpCompress/Writers/GZip/GZipWriter.cs` (+3 -3) 📝 `src/SharpCompress/Writers/Tar/TarWriter.cs` (+2 -2) 📝 `src/SharpCompress/Writers/Zip/ZipWriter.cs` (+2 -2) 📝 `tests/SharpCompress.Test/ArchiveTests.cs` (+2 -2) 📝 `tests/SharpCompress.Test/ReaderTests.cs` (+2 -2) 📝 `tests/SharpCompress.Test/Streams/ZlibBaseStreamTests.cs` (+2 -2) 📝 `tests/SharpCompress.Test/WriterTests.cs` (+2 -2) 📝 `tests/SharpCompress.Test/Zip/ZipReaderTests.cs` (+1 -1) </details> ### 📄 Description Suppresses the creation of a `NonDisposingStream` which wrappes another `NonDisposingStream` with same settings --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:19:15 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1157
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?