starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-12 05:25:03 +00:00
Code Issues 975 Packages Projects Releases 22 Wiki Activity

[PR #687] [MERGED] SourceStream Position counting bug fix #1164

New Issue
Open
opened 2026-01-29 22:19:18 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:19:18 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/687
Author: @Erior
Created: 7/30/2022
Status: ✅ Merged
Merged: 8/1/2022
Merged by: @adamhathcock

Base: master ← Head: feature/SourceStreamPositionCountingBug

📝 Commits (1)

  • 0ae7563 SourceStream Position counting bug fix

📊 Changes

2 files changed (+10 additions, -4 deletions)

View changed files

📝 src/SharpCompress/IO/SourceStream.cs (+10 -2)
📝 src/SharpCompress/Utility.cs (+0 -2)

📄 Description

Encountered a position counting bug, it add the stream size even if the stream is not switched.
This should fix it and I also removed the workaround I had.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/687 **Author:** [@Erior](https://github.com/Erior) **Created:** 7/30/2022 **Status:** ✅ Merged **Merged:** 8/1/2022 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `feature/SourceStreamPositionCountingBug` --- ### 📝 Commits (1) - [`0ae7563`](https://github.com/adamhathcock/sharpcompress/commit/0ae75634b1597c800cffcc51625ed536f3d8980b) SourceStream Position counting bug fix ### 📊 Changes **2 files changed** (+10 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/IO/SourceStream.cs` (+10 -2) 📝 `src/SharpCompress/Utility.cs` (+0 -2) </details> ### 📄 Description Encountered a position counting bug, it add the stream size even if the stream is not switched. This should fix it and I also removed the workaround I had. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:19:18 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1164
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?