starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-10 13:39:12 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #686] [MERGED] Mitigation of problems #1166

New Issue
Closed
opened 2026-01-29 22:19:18 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:19:18 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/686
Author: @Erior
Created: 7/28/2022
Status: ✅ Merged
Merged: 7/29/2022
Merged by: @adamhathcock

Base: master ← Head: 477

📝 Commits (3)

  • 7c56df1 Mitigation of problems
  • ad633a9 missing test file from error report
  • 5706732 Naive implementation of searching of DataDescriptor, not compatible with big archives (>32bit), but handles test cases.

📊 Changes

6 files changed (+91 additions, -7 deletions)

View changed files

📝 src/SharpCompress/Common/Zip/StreamingZipFilePart.cs (+29 -3)
📝 src/SharpCompress/Readers/AbstractReader.cs (+1 -1)
📝 src/SharpCompress/Utility.cs (+35 -0)
📝 tests/SharpCompress.Test/Zip/ZipArchiveTests.cs (+9 -2)
📝 tests/SharpCompress.Test/Zip/ZipReaderTests.cs (+17 -1)
➕ tests/TestArchives/Archives/test_477.zip (+0 -0)

📄 Description

Mitigations of the problems found, we still need to either make the Archive tell Reader about the CompressedSizes of the archive or make a search for DataDescriptor, or both since that would increase performace in general, no need to decompress if we know the compressed size, current code is already handling that.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/686 **Author:** [@Erior](https://github.com/Erior) **Created:** 7/28/2022 **Status:** ✅ Merged **Merged:** 7/29/2022 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `477` --- ### 📝 Commits (3) - [`7c56df1`](https://github.com/adamhathcock/sharpcompress/commit/7c56df1237e98a6478516d338b16b1f06daf303d) Mitigation of problems - [`ad633a9`](https://github.com/adamhathcock/sharpcompress/commit/ad633a9dd0b87679040d9f9582bd5f141f9613e7) missing test file from error report - [`5706732`](https://github.com/adamhathcock/sharpcompress/commit/5706732c55fff25f4f57b8b082c1fb89359ffd6c) Naive implementation of searching of DataDescriptor, not compatible with big archives (>32bit), but handles test cases. ### 📊 Changes **6 files changed** (+91 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Common/Zip/StreamingZipFilePart.cs` (+29 -3) 📝 `src/SharpCompress/Readers/AbstractReader.cs` (+1 -1) 📝 `src/SharpCompress/Utility.cs` (+35 -0) 📝 `tests/SharpCompress.Test/Zip/ZipArchiveTests.cs` (+9 -2) 📝 `tests/SharpCompress.Test/Zip/ZipReaderTests.cs` (+17 -1) ➕ `tests/TestArchives/Archives/test_477.zip` (+0 -0) </details> ### 📄 Description Mitigations of the problems found, we still need to either make the Archive tell Reader about the CompressedSizes of the archive or make a search for DataDescriptor, or both since that would increase performace in general, no need to decompress if we know the compressed size, current code is already handling that. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:19:18 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1166
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?