ZipReader, Entry.Key encoding is not UTF8 #117

New Issue

claunia · 2026-01-29T22:06:49Z

claunia commented

2026-01-29 22:06:49 +00:00

Originally created by @WilhelmJP on GitHub (Aug 15, 2016).

File names with german umlauts are not unzipped correctly. Therfore searching for a certain key will not work. Here is my code snipped:

        using (var reader = Compress.Reader.Zip.ZipReader.Open(stream, pwd))
        {
            while (reader.MoveToNextEntry())
            {
                if (!reader.Entry.IsDirectory)
                {
                    using (var ms = new MemoryStream())
                    {
                        reader.WriteEntryTo(ms);
                        // if(reader.Entry.Key == "Büro can be found") smile;
                        archive.Add(reader.Entry.Key, ms.ToArray());
                    }
                }
            }
        }

Best
Wilhelm

Originally created by @WilhelmJP on GitHub (Aug 15, 2016). File names with german umlauts are not unzipped correctly. Therfore searching for a certain key will not work. Here is my code snipped: ``` using (var reader = Compress.Reader.Zip.ZipReader.Open(stream, pwd)) { while (reader.MoveToNextEntry()) { if (!reader.Entry.IsDirectory) { using (var ms = new MemoryStream()) { reader.WriteEntryTo(ms); // if(reader.Entry.Key == "Büro can be found") smile; archive.Add(reader.Entry.Key, ms.ToArray()); } } } } ``` Best Wilhelm

claunia commented

2026-01-29 22:06:50 +00:00

@adamhathcock commented on GitHub (Aug 20, 2016):

Does it help if you change the ArchiveEncoding class?

@adamhathcock commented on GitHub (Aug 20, 2016): Does it help if you change the ArchiveEncoding class?

claunia commented

2026-01-29 22:06:50 +00:00

@k003bzw commented on GitHub (Aug 25, 2016):

it also does not work. You can use my project file to test the ArchiveEncoding class.
Project.zip

@k003bzw commented on GitHub (Aug 25, 2016): it also does not work. You can use my project file to test the ArchiveEncoding class. [Project.zip](https://github.com/adamhathcock/sharpcompress/files/436341/Project.zip)

claunia commented

2026-01-29 22:06:50 +00:00

@adamhathcock commented on GitHub (Sep 27, 2016):

The extract seems to work for me.

I did this:

 using (TestStream stream = new TestStream(File.OpenRead("C:\\Users\\hathcoa\\Downloads\\Project.zip")))
            {
                using (var reader = ReaderFactory.Open(stream))
                {
                    while (reader.MoveToNextEntry())
                    {
                        if (!reader.Entry.IsDirectory)
                        {
                            reader.WriteEntryToDirectory(SCRATCH_FILES_PATH,
                                                         new ExtractionOptions()
                                                         {
                                                             ExtractFullPath = true,
                                                             Overwrite = true
                                                         });
                        }
                    }
                }
                Assert.True(stream.IsDisposed);
            }

@adamhathcock commented on GitHub (Sep 27, 2016): The extract seems to work for me. I did this: ``` using (TestStream stream = new TestStream(File.OpenRead("C:\\Users\\hathcoa\\Downloads\\Project.zip"))) { using (var reader = ReaderFactory.Open(stream)) { while (reader.MoveToNextEntry()) { if (!reader.Entry.IsDirectory) { reader.WriteEntryToDirectory(SCRATCH_FILES_PATH, new ExtractionOptions() { ExtractFullPath = true, Overwrite = true }); } } } Assert.True(stream.IsDisposed); } ```

claunia commented

2026-01-29 22:06:51 +00:00

@adamhathcock commented on GitHub (Sep 27, 2016):

Created an Archive like this and the character was fine:

  using (var archive = ZipArchive.Create())
            {
                using (TestStream stream = new TestStream(File.OpenRead("C:\\Users\\hathcoa\\Downloads\\Project.zip")))
                {
                    using (var reader = ReaderFactory.Open(stream))
                    {
                        while (reader.MoveToNextEntry())
                        {
                            if (!reader.Entry.IsDirectory)
                            {
                                var ms = new MemoryStream();
                                reader.WriteEntryTo(ms);
                                ms.Position = 0;
                                archive.AddEntry(reader.Entry.Key, ms);
                            }
                        }
                    }
                    Assert.True(stream.IsDisposed);
                }
                archive.SaveTo(File.OpenWrite("C:\\Users\\hathcoa\\Downloads\\Project2.zip"));
            }

@adamhathcock commented on GitHub (Sep 27, 2016): Created an Archive like this and the character was fine: ``` using (var archive = ZipArchive.Create()) { using (TestStream stream = new TestStream(File.OpenRead("C:\\Users\\hathcoa\\Downloads\\Project.zip"))) { using (var reader = ReaderFactory.Open(stream)) { while (reader.MoveToNextEntry()) { if (!reader.Entry.IsDirectory) { var ms = new MemoryStream(); reader.WriteEntryTo(ms); ms.Position = 0; archive.AddEntry(reader.Entry.Key, ms); } } } Assert.True(stream.IsDisposed); } archive.SaveTo(File.OpenWrite("C:\\Users\\hathcoa\\Downloads\\Project2.zip")); } ```

claunia commented

2026-01-29 22:06:51 +00:00

@Wagalv commented on GitHub (Nov 24, 2016):

I had the same issue, but for Portuguese and Spanish characters. To solve this I used the follow code:

using (Stream stream = File.OpenRead(path))
{
SharpCompress.Common.ArchiveEncoding.Default = System.Text.Encoding.GetEncoding(850);
var reader = ReaderFactory.Open(stream, Options.None);
while (reader.MoveToNextEntry())
{
if (!reader.Entry.IsDirectory)
{
reader.WriteEntryToDirectory(savePath, ExtractOptions.ExtractFullPath | ExtractOptions.Overwrite);
}
}

@Wagalv commented on GitHub (Nov 24, 2016): I had the same issue, but for Portuguese and Spanish characters. To solve this I used the follow code: using (Stream stream = File.OpenRead(path)) { SharpCompress.Common.ArchiveEncoding.Default = System.Text.Encoding.GetEncoding(850); var reader = ReaderFactory.Open(stream, Options.None); while (reader.MoveToNextEntry()) { if (!reader.Entry.IsDirectory) { reader.WriteEntryToDirectory(savePath, ExtractOptions.ExtractFullPath | ExtractOptions.Overwrite); } }

Sign in to join this conversation.

Branches Tags

master

release

adam/merge-release-to-master

dependabot/nuget/xunit.v3-3.2.2

adam/more-explode-async

copilot/fix-infinite-loop-rar-archive

adam/data-descriptor-fix

adam/fix-tests-with-proper-rewind

copilot/fix-data-descriptor-stream-bug

adam/lmza-investigation

adam/create-rar-async

adam/async-rar2

copilot/support-multi-threading-path

copilot/sub-pr-1132-again

adam/memory-perf

copilot/add-performance-benchmarking

copilot/sub-pr-1121

copilot/add-password-support-zip-files

copilot/add-so-optimized-zip-support

adam/rar-async-only

copilot/add-buffered-stream-async-read

copilot/sub-pr-1076

copilot/fix-decompression-exception

copilot/fix-archivefactory-issue

copilot/rationalize-sourcestream-volumes

adam/open-async

copilot/add-ace-archive-support

copilot/sub-pr-1040-again

adam/more-async-3

copilot/fix-tararchive-incomplete-iteration

adam/multi-threaded

copilot/sub-pr-1040

adam/awesome-copilot

copilot/fix-ziparchive-extraction-issue

copilot/fix-tararchive-open-crash

copilot/fix-tar-xz-file-reading-issue

copilot/setup-copilot-instructions

copilot/fix-decompression-performance-issue

copilot/convert-stream-access-to-async

adam/enable-agent

adam/async-deflate

adam/async-rar

adam/more-cleanup

adam/zstd

async-2

zstandard

net461-tests

dmg

async

build-netcore3

recycle-memory-stream

presentation

pax

netcore2

zip_encryption

dotnet-tool

tar_redux

native_zlib

Issue-197

system_buffers

TarNames

7zip_sfx

portable_crypto

WinRT

new_7zip

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/sharpcompress#117