starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #735] [MERGED] Remove check for minimal distance and add test case generated by 7z as compatibility check #1193

New Issue
Open
opened 2026-01-29 22:19:25 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:19:25 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/735
Author: @Erior
Created: 3/19/2023
Status: ✅ Merged
Merged: 3/21/2023
Merged by: @adamhathcock

Base: master ← Head: feature/Expand-Delta-distance-tests

📝 Commits (2)

  • 23a9ca3 Delta distance
  • 9544960 Merge branch 'master' into feature/Expand-Delta-distance-tests

📊 Changes

4 files changed (+30 additions, -6 deletions)

View changed files

📝 src/SharpCompress/Compressors/Filters/DeltaFilter.cs (+0 -5)
📝 tests/SharpCompress.Test/ArchiveTests.cs (+25 -0)
📝 tests/SharpCompress.Test/SevenZip/SevenZipArchiveTests.cs (+5 -1)
➕ tests/TestArchives/Archives/7Zip.delta.distance.7z (+0 -0)

📄 Description

Hi

It seems the check for minimal distance in the Delta filter that I added is wrong, added test case generated by 7z as proof
Sorry for the inconvenience.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/735 **Author:** [@Erior](https://github.com/Erior) **Created:** 3/19/2023 **Status:** ✅ Merged **Merged:** 3/21/2023 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `feature/Expand-Delta-distance-tests` --- ### 📝 Commits (2) - [`23a9ca3`](https://github.com/adamhathcock/sharpcompress/commit/23a9ca3140e1bd8235a99c5b72eb30a859ae34f7) Delta distance - [`9544960`](https://github.com/adamhathcock/sharpcompress/commit/95449603143e8b020eba38a295466d7ca02d8006) Merge branch 'master' into feature/Expand-Delta-distance-tests ### 📊 Changes **4 files changed** (+30 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Compressors/Filters/DeltaFilter.cs` (+0 -5) 📝 `tests/SharpCompress.Test/ArchiveTests.cs` (+25 -0) 📝 `tests/SharpCompress.Test/SevenZip/SevenZipArchiveTests.cs` (+5 -1) ➕ `tests/TestArchives/Archives/7Zip.delta.distance.7z` (+0 -0) </details> ### 📄 Description Hi It seems the check for minimal distance in the Delta filter that I added is wrong, added test case generated by 7z as proof Sorry for the inconvenience. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:19:25 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1193
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?