starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-11 21:22:10 +00:00
Code Issues 975 Packages Projects Releases 22 Wiki Activity

[PR #780] [MERGED] Revert change disabling strong name signing in 92df1ec #1218

New Issue
Open
opened 2026-01-29 22:19:32 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:19:32 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/780
Author: @caesay
Created: 11/14/2023
Status: ✅ Merged
Merged: 11/15/2023
Merged by: @adamhathcock

Base: master ← Head: cs/revert-disable-strongname

📝 Commits (2)

  • 43f86bc Revert change disabling strong name signing in 92df1ec
  • 2777b64 Merge branch 'master' into cs/revert-disable-strongname

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/SharpCompress/SharpCompress.csproj (+2 -2)

📄 Description

As title mentions. Strong name signing was disabled via 92df1ec in a large merge adding zstd support.

Due to this comment from @adamhathcock, I believe this was just a mistake. So here is a PR which resolves the issue.

Accepting this PR will fix #764

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/780 **Author:** [@caesay](https://github.com/caesay) **Created:** 11/14/2023 **Status:** ✅ Merged **Merged:** 11/15/2023 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `cs/revert-disable-strongname` --- ### 📝 Commits (2) - [`43f86bc`](https://github.com/adamhathcock/sharpcompress/commit/43f86bcab820ed3ddb025735bd29af30f17ac11c) Revert change disabling strong name signing in 92df1ec - [`2777b64`](https://github.com/adamhathcock/sharpcompress/commit/2777b6411f0068cd246cbe223e7947df06bb2176) Merge branch 'master' into cs/revert-disable-strongname ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/SharpCompress.csproj` (+2 -2) </details> ### 📄 Description As title mentions. Strong name signing was disabled via 92df1ec in a large merge adding zstd support. Due to [this comment from @adamhathcock](https://github.com/adamhathcock/sharpcompress/issues/764#issuecomment-1723218890), I believe this was just a mistake. So here is a PR which resolves the issue. Accepting this PR will fix #764 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:19:32 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1218
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?