starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #784] [MERGED] Dont crash on reading rar5 comment #783 #1221

New Issue
Open
opened 2026-01-29 22:19:32 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:19:32 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/784
Author: @Erior
Created: 12/4/2023
Status: ✅ Merged
Merged: 12/11/2023
Merged by: @adamhathcock

Base: master ← Head: feature/rar-comment

📝 Commits (2)

📊 Changes

5 files changed (+16 additions, -6 deletions)

View changed files

📝 src/SharpCompress/Common/Rar/Headers/RarHeaderFactory.cs (+8 -1)
📝 src/SharpCompress/Common/Rar/RarVolume.cs (+2 -5)
📝 tests/SharpCompress.Test/Rar/RarReaderTests.cs (+6 -0)
➕ tests/TestArchives/Archives/Rar.comment.rar (+0 -0)
➕ tests/TestArchives/Archives/Rar5.comment.rar (+0 -0)

📄 Description

Before we skipped the Service, this changed with #697 however, no tests was added and resulted in #783

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/784 **Author:** [@Erior](https://github.com/Erior) **Created:** 12/4/2023 **Status:** ✅ Merged **Merged:** 12/11/2023 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `feature/rar-comment` --- ### 📝 Commits (2) - [`ca49176`](https://github.com/adamhathcock/sharpcompress/commit/ca49176b971f8b48631b2bbb30d02b112b963767) Dont crash on reading rar5 comment - [`7f6f7b1`](https://github.com/adamhathcock/sharpcompress/commit/7f6f7b1436a1b2d841191c48625568f15f075742) Resharpier fix ### 📊 Changes **5 files changed** (+16 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Common/Rar/Headers/RarHeaderFactory.cs` (+8 -1) 📝 `src/SharpCompress/Common/Rar/RarVolume.cs` (+2 -5) 📝 `tests/SharpCompress.Test/Rar/RarReaderTests.cs` (+6 -0) ➕ `tests/TestArchives/Archives/Rar.comment.rar` (+0 -0) ➕ `tests/TestArchives/Archives/Rar5.comment.rar` (+0 -0) </details> ### 📄 Description Before we skipped the Service, this changed with #697 however, no tests was added and resulted in #783 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:19:32 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1221
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?