starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #780] Revert change disabling strong name signing in 92df1ec #1222

New Issue
Open
opened 2026-01-29 22:19:32 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:19:32 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/adamhathcock/sharpcompress/pull/780

State: closed
Merged: Yes

As title mentions. Strong name signing was disabled via 92df1ec in a large merge adding zstd support.

Due to this comment from @adamhathcock, I believe this was just a mistake. So here is a PR which resolves the issue.

Accepting this PR will fix #764

**Original Pull Request:** https://github.com/adamhathcock/sharpcompress/pull/780 **State:** closed **Merged:** Yes --- As title mentions. Strong name signing was disabled via 92df1ec in a large merge adding zstd support. Due to [this comment from @adamhathcock](https://github.com/adamhathcock/sharpcompress/issues/764#issuecomment-1723218890), I believe this was just a mistake. So here is a PR which resolves the issue. Accepting this PR will fix #764
claunia added the pull-request label 2026-01-29 22:19:32 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1222
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?