starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-12 05:25:03 +00:00
Code Issues 975 Packages Projects Releases 22 Wiki Activity

[PR #786] [MERGED] LZMA EOS marker detection #1227

New Issue
Open
opened 2026-01-29 22:19:34 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:19:34 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/786
Author: @Erior
Created: 12/9/2023
Status: ✅ Merged
Merged: 12/11/2023
Merged by: @adamhathcock

Base: master ← Head: feature/Issue-774

📝 Commits (1)

  • 0320db6 LZMA EOS marker detection

📊 Changes

3 files changed (+14 additions, -2 deletions)

View changed files

📝 src/SharpCompress/Compressors/LZMA/LzmaStream.cs (+11 -2)
📝 tests/SharpCompress.Test/SevenZip/SevenZipArchiveTests.cs (+3 -0)
➕ tests/TestArchives/Archives/7Zip.eos.7z (+0 -0)

📄 Description

The DataError in #774 comes from the LZMA stream having EOS bytes at the end, we would need to check if the stream has it or not before raising DataError.

Added a test archive generated from 7za with the -meos flag set.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/786 **Author:** [@Erior](https://github.com/Erior) **Created:** 12/9/2023 **Status:** ✅ Merged **Merged:** 12/11/2023 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `feature/Issue-774` --- ### 📝 Commits (1) - [`0320db6`](https://github.com/adamhathcock/sharpcompress/commit/0320db6b4ad4e6ec06504bacce1567161dda8573) LZMA EOS marker detection ### 📊 Changes **3 files changed** (+14 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Compressors/LZMA/LzmaStream.cs` (+11 -2) 📝 `tests/SharpCompress.Test/SevenZip/SevenZipArchiveTests.cs` (+3 -0) ➕ `tests/TestArchives/Archives/7Zip.eos.7z` (+0 -0) </details> ### 📄 Description The DataError in #774 comes from the LZMA stream having EOS bytes at the end, we would need to check if the stream has it or not before raising DataError. Added a test archive generated from 7za with the -meos flag set. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:19:34 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1227
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?