starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-09 21:24:08 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #794] [MERGED] Feature/rar5 blake2 #1236

New Issue
Closed
opened 2026-01-29 22:19:36 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:19:36 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/794
Author: @Erior
Created: 1/2/2024
Status: ✅ Merged
Merged: 1/3/2024
Merged by: @adamhathcock

Base: master ← Head: feature/rar5-blake2

📝 Commits (4)

  • 388bbe0 Blake2 Archive test OK
  • f8a0069 Calc checksum when encrypted is not working for RAR5, disable for now
  • 8b02795 CSharpier
  • 4f749da Merge branch 'develop' into feature/rar5-blake2

📊 Changes

10 files changed (+350 additions, -38 deletions)

View changed files

📝 README.md (+1 -1)
📝 src/SharpCompress/Archives/Rar/RarArchiveEntry.cs (+5 -1)
📝 src/SharpCompress/Common/Rar/Headers/FileHeader.cs (+9 -19)
📝 src/SharpCompress/Common/Rar/RarEntry.cs (+1 -1)
📝 src/SharpCompress/Compressors/Rar/MultiVolumeReadOnlyStream.cs (+1 -1)
➕ src/SharpCompress/Compressors/Rar/RarBLAKE2spStream.cs (+305 -0)
📝 src/SharpCompress/Compressors/Rar/RarCrcStream.cs (+8 -1)
📝 src/SharpCompress/Readers/Rar/RarReader.cs (+8 -0)
📝 tests/SharpCompress.Test/Rar/RarArchiveTests.cs (+3 -0)
📝 tests/SharpCompress.Test/Rar/RarReaderTests.cs (+9 -14)

📄 Description

A Blake2 impl for RAR5, while testing it out I noticed that CRC and probably Blake2 for RAR5 with encryption is broken, the check is disabled for now when this is detectde. Exposes only the first 4 bytes for the Blake2 CRC externally to keep current API.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/794 **Author:** [@Erior](https://github.com/Erior) **Created:** 1/2/2024 **Status:** ✅ Merged **Merged:** 1/3/2024 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `feature/rar5-blake2` --- ### 📝 Commits (4) - [`388bbe0`](https://github.com/adamhathcock/sharpcompress/commit/388bbe047e7be4a89eb3e6171c1cc3a44ce348e1) Blake2 Archive test OK - [`f8a0069`](https://github.com/adamhathcock/sharpcompress/commit/f8a0069a5dbe1d73c78824847c9e6579008440d6) Calc checksum when encrypted is not working for RAR5, disable for now - [`8b02795`](https://github.com/adamhathcock/sharpcompress/commit/8b02795d699bf2730f9b7f16b34c4db25cedd635) CSharpier - [`4f749da`](https://github.com/adamhathcock/sharpcompress/commit/4f749da6282492c5df200ea85b131b287be8421b) Merge branch 'develop' into feature/rar5-blake2 ### 📊 Changes **10 files changed** (+350 additions, -38 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+1 -1) 📝 `src/SharpCompress/Archives/Rar/RarArchiveEntry.cs` (+5 -1) 📝 `src/SharpCompress/Common/Rar/Headers/FileHeader.cs` (+9 -19) 📝 `src/SharpCompress/Common/Rar/RarEntry.cs` (+1 -1) 📝 `src/SharpCompress/Compressors/Rar/MultiVolumeReadOnlyStream.cs` (+1 -1) ➕ `src/SharpCompress/Compressors/Rar/RarBLAKE2spStream.cs` (+305 -0) 📝 `src/SharpCompress/Compressors/Rar/RarCrcStream.cs` (+8 -1) 📝 `src/SharpCompress/Readers/Rar/RarReader.cs` (+8 -0) 📝 `tests/SharpCompress.Test/Rar/RarArchiveTests.cs` (+3 -0) 📝 `tests/SharpCompress.Test/Rar/RarReaderTests.cs` (+9 -14) </details> ### 📄 Description A Blake2 impl for RAR5, while testing it out I noticed that CRC and probably Blake2 for RAR5 with encryption is broken, the check is disabled for now when this is detectde. Exposes only the first 4 bytes for the Blake2 CRC externally to keep current API. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:19:36 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1236
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?