starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #798] [MERGED] Set Empty string for Rar5 password as default #1237

New Issue
Closed
opened 2026-01-29 22:19:36 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:19:36 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/798
Author: @Erior
Created: 1/4/2024
Status: ✅ Merged
Merged: 1/8/2024
Merged by: @adamhathcock

Base: master ← Head: feature/Fix-crash-when-not-setting-password-for-rar5

📝 Commits (2)

  • 6c157de set empty string if password not set
  • 46d4b26 Fix testing under Linux

📊 Changes

5 files changed (+135 additions, -1 deletions)

View changed files

📝 src/SharpCompress/Common/Rar/CryptKey5.cs (+1 -1)
📝 tests/SharpCompress.Test/ArchiveTests.cs (+23 -0)
📝 tests/SharpCompress.Test/Rar/RarArchiveTests.cs (+30 -0)
📝 tests/SharpCompress.Test/Rar/RarReaderTests.cs (+51 -0)
📝 tests/SharpCompress.Test/ReaderTests.cs (+30 -0)

📄 Description

#783

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/798 **Author:** [@Erior](https://github.com/Erior) **Created:** 1/4/2024 **Status:** ✅ Merged **Merged:** 1/8/2024 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `feature/Fix-crash-when-not-setting-password-for-rar5` --- ### 📝 Commits (2) - [`6c157de`](https://github.com/adamhathcock/sharpcompress/commit/6c157def4b84f17c69d9291dd8db7761442b67ad) set empty string if password not set - [`46d4b26`](https://github.com/adamhathcock/sharpcompress/commit/46d4b26ebadb8dc2d715628ebbc30ca3d9295054) Fix testing under Linux ### 📊 Changes **5 files changed** (+135 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Common/Rar/CryptKey5.cs` (+1 -1) 📝 `tests/SharpCompress.Test/ArchiveTests.cs` (+23 -0) 📝 `tests/SharpCompress.Test/Rar/RarArchiveTests.cs` (+30 -0) 📝 `tests/SharpCompress.Test/Rar/RarReaderTests.cs` (+51 -0) 📝 `tests/SharpCompress.Test/ReaderTests.cs` (+30 -0) </details> ### 📄 Description #783 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:19:36 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1237
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?