starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-09 21:24:08 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #801] [MERGED] Issue 771, remove throw on flush for readonly streams #1240

New Issue
Open
opened 2026-01-29 22:19:37 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:19:37 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/801
Author: @Erior
Created: 1/5/2024
Status: ✅ Merged
Merged: 1/8/2024
Merged by: @adamhathcock

Base: master ← Head: feature/771

📝 Commits (1)

  • 4477833 Issue 771, remove throw on flush for readonly streams

📊 Changes

16 files changed (+25 additions, -28 deletions)

View changed files

📝 src/SharpCompress/Common/Rar/RarCryptoWrapper.cs (+1 -1)
📝 src/SharpCompress/Common/SevenZip/ArchiveReader.cs (+1 -1)
📝 src/SharpCompress/Common/Tar/TarReadOnlySubStream.cs (+2 -2)
📝 src/SharpCompress/Common/Zip/PkwareTraditionalCryptoStream.cs (+2 -5)
📝 src/SharpCompress/Common/Zip/WinzipAesCryptoStream.cs (+1 -1)
📝 src/SharpCompress/Compressors/Filters/BCJ2Filter.cs (+2 -2)
📝 src/SharpCompress/Compressors/Filters/Filter.cs (+2 -2)
📝 src/SharpCompress/Compressors/LZMA/DecoderStream.cs (+2 -2)
📝 src/SharpCompress/Compressors/Rar/MultiVolumeReadOnlyStream.cs (+1 -1)
📝 src/SharpCompress/Compressors/Xz/ReadOnlyStream.cs (+2 -2)
📝 src/SharpCompress/IO/BufferedSubStream.cs (+2 -2)
📝 src/SharpCompress/IO/DataDescriptorStream.cs (+1 -1)
📝 src/SharpCompress/IO/ReadOnlySubStream.cs (+1 -1)
📝 src/SharpCompress/IO/RewindableStream.cs (+1 -1)
📝 tests/SharpCompress.Test/Mocks/FlushOnDisposeStream.cs (+2 -2)
📝 tests/SharpCompress.Test/Mocks/ForwardOnlyStream.cs (+2 -2)

📄 Description

#771 , remove throwing NotSupported for flush

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/801 **Author:** [@Erior](https://github.com/Erior) **Created:** 1/5/2024 **Status:** ✅ Merged **Merged:** 1/8/2024 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `feature/771` --- ### 📝 Commits (1) - [`4477833`](https://github.com/adamhathcock/sharpcompress/commit/4477833b1d44a7a60c3e92dcf4587d9d0060f883) Issue 771, remove throw on flush for readonly streams ### 📊 Changes **16 files changed** (+25 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Common/Rar/RarCryptoWrapper.cs` (+1 -1) 📝 `src/SharpCompress/Common/SevenZip/ArchiveReader.cs` (+1 -1) 📝 `src/SharpCompress/Common/Tar/TarReadOnlySubStream.cs` (+2 -2) 📝 `src/SharpCompress/Common/Zip/PkwareTraditionalCryptoStream.cs` (+2 -5) 📝 `src/SharpCompress/Common/Zip/WinzipAesCryptoStream.cs` (+1 -1) 📝 `src/SharpCompress/Compressors/Filters/BCJ2Filter.cs` (+2 -2) 📝 `src/SharpCompress/Compressors/Filters/Filter.cs` (+2 -2) 📝 `src/SharpCompress/Compressors/LZMA/DecoderStream.cs` (+2 -2) 📝 `src/SharpCompress/Compressors/Rar/MultiVolumeReadOnlyStream.cs` (+1 -1) 📝 `src/SharpCompress/Compressors/Xz/ReadOnlyStream.cs` (+2 -2) 📝 `src/SharpCompress/IO/BufferedSubStream.cs` (+2 -2) 📝 `src/SharpCompress/IO/DataDescriptorStream.cs` (+1 -1) 📝 `src/SharpCompress/IO/ReadOnlySubStream.cs` (+1 -1) 📝 `src/SharpCompress/IO/RewindableStream.cs` (+1 -1) 📝 `tests/SharpCompress.Test/Mocks/FlushOnDisposeStream.cs` (+2 -2) 📝 `tests/SharpCompress.Test/Mocks/ForwardOnlyStream.cs` (+2 -2) </details> ### 📄 Description #771 , remove throwing NotSupported for flush --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:19:37 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1240
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?