starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #815] [MERGED] Code clean up #1252

New Issue
Open
opened 2026-01-29 22:19:39 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:19:39 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/815
Author: @adamhathcock
Created: 3/14/2024
Status: ✅ Merged
Merged: 3/14/2024
Merged by: @adamhathcock

Base: master ← Head: code-clean-up

📝 Commits (8)

📊 Changes

117 files changed (+1222 additions, -1751 deletions)

View changed files

📝 src/SharpCompress/Algorithms/Adler32.cs (+33 -33)
📝 src/SharpCompress/Archives/AbstractWritableArchive.cs (+3 -3)
📝 src/SharpCompress/Archives/ArchiveVolumeFactory.cs (+1 -1)
📝 src/SharpCompress/Archives/GZip/GZipArchive.cs (+1 -1)
📝 src/SharpCompress/Archives/Rar/RarArchive.cs (+3 -3)
📝 src/SharpCompress/Archives/Rar/RarArchiveVolumeFactory.cs (+1 -1)
📝 src/SharpCompress/Archives/Tar/TarArchive.cs (+1 -1)
📝 src/SharpCompress/Archives/Zip/ZipArchive.cs (+1 -1)
📝 src/SharpCompress/Archives/Zip/ZipArchiveVolumeFactory.cs (+1 -1)
📝 src/SharpCompress/Common/ExtractionMethods.cs (+5 -5)
📝 src/SharpCompress/Common/OptionsBase.cs (+1 -1)
➖ src/SharpCompress/Common/PasswordProtectedException.cs (+0 -12)
📝 src/SharpCompress/Common/Rar/CryptKey3.cs (+1 -4)
📝 src/SharpCompress/Common/Rar/CryptKey5.cs (+16 -18)
📝 src/SharpCompress/Common/Rar/Headers/ArchiveCryptHeader.cs (+2 -4)
📝 src/SharpCompress/Common/Rar/Rar5CryptoInfo.cs (+1 -3)
📝 src/SharpCompress/Common/Rar/RarCryptoBinaryReader.cs (+4 -13)
📝 src/SharpCompress/Common/Rar/RarCryptoWrapper.cs (+3 -5)
📝 src/SharpCompress/Common/SevenZip/ArchiveDatabase.cs (+7 -7)
📝 src/SharpCompress/Common/SevenZip/ArchiveReader.cs (+3 -3)

...and 80 more files

📄 Description

No description provided

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/815 **Author:** [@adamhathcock](https://github.com/adamhathcock) **Created:** 3/14/2024 **Status:** ✅ Merged **Merged:** 3/14/2024 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `code-clean-up` --- ### 📝 Commits (8) - [`0299232`](https://github.com/adamhathcock/sharpcompress/commit/0299232cb52031416a6f95b355ad84621f6b1043) just using rider to clean up - [`2715ae6`](https://github.com/adamhathcock/sharpcompress/commit/2715ae645d4b44e8ae17add990589bafb4bea14f) use var - [`5f13e24`](https://github.com/adamhathcock/sharpcompress/commit/5f13e245f007ea65f66446ae73d4f778c223a541) more clean up on tests - [`94d1503`](https://github.com/adamhathcock/sharpcompress/commit/94d1503c64c1101b91dc83dc3dbd3d21cea4ca27) more clean up - [`198a067`](https://github.com/adamhathcock/sharpcompress/commit/198a0673a2f11953ce5ad024340ca8d66ad60f32) more clean up - [`95975a4`](https://github.com/adamhathcock/sharpcompress/commit/95975a4c33662b602c8bc0a291a0db2353611c65) even more clean up - [`4afc7ae`](https://github.com/adamhathcock/sharpcompress/commit/4afc7ae2e4b1461c510ea33fa5043446a6cbdd8a) use complete namespace - [`3fa85fc`](https://github.com/adamhathcock/sharpcompress/commit/3fa85fc51626540b2ed5e7f4ba33bec077fce36b) Merge branch 'master' into code-clean-up ### 📊 Changes **117 files changed** (+1222 additions, -1751 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Algorithms/Adler32.cs` (+33 -33) 📝 `src/SharpCompress/Archives/AbstractWritableArchive.cs` (+3 -3) 📝 `src/SharpCompress/Archives/ArchiveVolumeFactory.cs` (+1 -1) 📝 `src/SharpCompress/Archives/GZip/GZipArchive.cs` (+1 -1) 📝 `src/SharpCompress/Archives/Rar/RarArchive.cs` (+3 -3) 📝 `src/SharpCompress/Archives/Rar/RarArchiveVolumeFactory.cs` (+1 -1) 📝 `src/SharpCompress/Archives/Tar/TarArchive.cs` (+1 -1) 📝 `src/SharpCompress/Archives/Zip/ZipArchive.cs` (+1 -1) 📝 `src/SharpCompress/Archives/Zip/ZipArchiveVolumeFactory.cs` (+1 -1) 📝 `src/SharpCompress/Common/ExtractionMethods.cs` (+5 -5) 📝 `src/SharpCompress/Common/OptionsBase.cs` (+1 -1) ➖ `src/SharpCompress/Common/PasswordProtectedException.cs` (+0 -12) 📝 `src/SharpCompress/Common/Rar/CryptKey3.cs` (+1 -4) 📝 `src/SharpCompress/Common/Rar/CryptKey5.cs` (+16 -18) 📝 `src/SharpCompress/Common/Rar/Headers/ArchiveCryptHeader.cs` (+2 -4) 📝 `src/SharpCompress/Common/Rar/Rar5CryptoInfo.cs` (+1 -3) 📝 `src/SharpCompress/Common/Rar/RarCryptoBinaryReader.cs` (+4 -13) 📝 `src/SharpCompress/Common/Rar/RarCryptoWrapper.cs` (+3 -5) 📝 `src/SharpCompress/Common/SevenZip/ArchiveDatabase.cs` (+7 -7) 📝 `src/SharpCompress/Common/SevenZip/ArchiveReader.cs` (+3 -3) _...and 80 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:19:39 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1252
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?