starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #832] [MERGED] Remove ignored nulls #1272

New Issue
Closed
opened 2026-01-29 22:19:45 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:19:45 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/832
Author: @adamhathcock
Created: 4/22/2024
Status: ✅ Merged
Merged: 4/23/2024
Merged by: @adamhathcock

Base: master ← Head: remove-ignored-nulls

📝 Commits (10+)

📊 Changes

75 files changed (+455 additions, -442 deletions)

View changed files

📝 .config/dotnet-tools.json (+1 -1)
📝 src/SharpCompress/Archives/AbstractArchive.cs (+23 -27)
📝 src/SharpCompress/Archives/AbstractWritableArchive.cs (+6 -2)
📝 src/SharpCompress/Archives/GZip/GZipArchive.cs (+12 -10)
📝 src/SharpCompress/Archives/GZip/GZipArchiveEntry.cs (+1 -1)
📝 src/SharpCompress/Archives/GZip/GZipWritableArchiveEntry.cs (+1 -3)
📝 src/SharpCompress/Archives/IArchiveEntryExtensions.cs (+1 -5)
📝 src/SharpCompress/Archives/IArchiveExtensions.cs (+1 -2)
📝 src/SharpCompress/Archives/Rar/FileInfoRarArchiveVolume.cs (+1 -1)
📝 src/SharpCompress/Archives/Rar/RarArchive.cs (+15 -17)
📝 src/SharpCompress/Archives/Rar/SeekableFilePart.cs (+10 -10)
📝 src/SharpCompress/Archives/Rar/StreamRarArchiveVolume.cs (+1 -1)
📝 src/SharpCompress/Archives/SevenZip/SevenZipArchive.cs (+48 -49)
📝 src/SharpCompress/Archives/Tar/TarArchive.cs (+14 -11)
📝 src/SharpCompress/Archives/Tar/TarArchiveEntry.cs (+1 -1)
📝 src/SharpCompress/Archives/Tar/TarWritableArchiveEntry.cs (+0 -2)
📝 src/SharpCompress/Archives/Zip/ZipArchive.cs (+21 -21)
📝 src/SharpCompress/Common/ArchiveEncoding.cs (+4 -2)
📝 src/SharpCompress/Common/Entry.cs (+4 -4)
📝 src/SharpCompress/Common/ExtractionMethods.cs (+3 -2)

...and 55 more files

📄 Description

lessen the usage of ! and clean up which should make #831 better

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/832 **Author:** [@adamhathcock](https://github.com/adamhathcock) **Created:** 4/22/2024 **Status:** ✅ Merged **Merged:** 4/23/2024 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `remove-ignored-nulls` --- ### 📝 Commits (10+) - [`e96366f`](https://github.com/adamhathcock/sharpcompress/commit/e96366f4895dbb13fcc8b2fb40d945bd27ef4bfc) Entry can be null and remove other ! usages - [`fb55624`](https://github.com/adamhathcock/sharpcompress/commit/fb55624f5f74108a629d62ceacfcf58b6f7dbaec) add more null handling - [`b550df2`](https://github.com/adamhathcock/sharpcompress/commit/b550df20380c3b9cd8f81b685255d8ce10e26ba5) get rid of more ! and update csharpier - [`7963233`](https://github.com/adamhathcock/sharpcompress/commit/7963233702a07af04d7d93f2616699290e019ade) add missing usings - [`f24bfdf`](https://github.com/adamhathcock/sharpcompress/commit/f24bfdf945c6f16885a89bd83196e51efa8f3e9d) fix tests - [`99e2c8c`](https://github.com/adamhathcock/sharpcompress/commit/99e2c8c90d44d59681a0004645ca147fe4c820ba) more clean up - [`7ebdc85`](https://github.com/adamhathcock/sharpcompress/commit/7ebdc85ad2ec1fa97e904dfea15b096329cbc490) more null clean up - [`c73ca21`](https://github.com/adamhathcock/sharpcompress/commit/c73ca21b4d580a7dde427bd06817050aa936693e) fmt - [`23dd041`](https://github.com/adamhathcock/sharpcompress/commit/23dd041e2e584ee7dd5f25962f0148c2577d96d5) fix some tests - [`b94e75f`](https://github.com/adamhathcock/sharpcompress/commit/b94e75fabeaea175d139e71183d6ed085b248bbc) try to fix more tests ### 📊 Changes **75 files changed** (+455 additions, -442 deletions) <details> <summary>View changed files</summary> 📝 `.config/dotnet-tools.json` (+1 -1) 📝 `src/SharpCompress/Archives/AbstractArchive.cs` (+23 -27) 📝 `src/SharpCompress/Archives/AbstractWritableArchive.cs` (+6 -2) 📝 `src/SharpCompress/Archives/GZip/GZipArchive.cs` (+12 -10) 📝 `src/SharpCompress/Archives/GZip/GZipArchiveEntry.cs` (+1 -1) 📝 `src/SharpCompress/Archives/GZip/GZipWritableArchiveEntry.cs` (+1 -3) 📝 `src/SharpCompress/Archives/IArchiveEntryExtensions.cs` (+1 -5) 📝 `src/SharpCompress/Archives/IArchiveExtensions.cs` (+1 -2) 📝 `src/SharpCompress/Archives/Rar/FileInfoRarArchiveVolume.cs` (+1 -1) 📝 `src/SharpCompress/Archives/Rar/RarArchive.cs` (+15 -17) 📝 `src/SharpCompress/Archives/Rar/SeekableFilePart.cs` (+10 -10) 📝 `src/SharpCompress/Archives/Rar/StreamRarArchiveVolume.cs` (+1 -1) 📝 `src/SharpCompress/Archives/SevenZip/SevenZipArchive.cs` (+48 -49) 📝 `src/SharpCompress/Archives/Tar/TarArchive.cs` (+14 -11) 📝 `src/SharpCompress/Archives/Tar/TarArchiveEntry.cs` (+1 -1) 📝 `src/SharpCompress/Archives/Tar/TarWritableArchiveEntry.cs` (+0 -2) 📝 `src/SharpCompress/Archives/Zip/ZipArchive.cs` (+21 -21) 📝 `src/SharpCompress/Common/ArchiveEncoding.cs` (+4 -2) 📝 `src/SharpCompress/Common/Entry.cs` (+4 -4) 📝 `src/SharpCompress/Common/ExtractionMethods.cs` (+3 -2) _...and 55 more files_ </details> ### 📄 Description lessen the usage of `!` and clean up which should make #831 better --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:19:45 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1272
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?