mirror of
https://github.com/adamhathcock/sharpcompress.git
synced 2026-02-09 05:24:55 +00:00
Writer Factory #128
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @gaffo on GitHub (Sep 25, 2016).
Seems overly complicated. You've got a bunch of optional flags depending on what' we're doing.
How about you just enumerate them in code or say "Just use ZipWriter directly?"
@adamhathcock commented on GitHub (Sep 26, 2016):
I should probably just refactor and consolidate options into a real object.
Do you have other suggestions?
@gaffo commented on GitHub (Sep 26, 2016):
I think enumerating the options into classes would be great. Either that or
nestable streams. Either of these would make the interface a bit cleaner. I ended up reading through the source of WriterFactory to see what options I should pass in and then just created the objects directly. So writer factory worked as an example but without documentation it's confusing. Like what are the possible compressions that can work with zip? tar?
Just some feedback on onboarding to the library. You can take as a data point.
On Sep 26, 2016 1:39 AM, "Adam Hathcock" notifications@github.com wrote:
@adamhathcock commented on GitHub (Sep 26, 2016):
What divide by zero?
It is amateur. No one is getting paid or ever has been paid for this. The quality of this project in way no reflects he code I write professionally nor any contributor I'm sure. This is a volunteer thing and it's surprising anyone relies on this in a professional manner without contributing considering how little work goes into this project in recent years.
Why say something like that?
@gaffo commented on GitHub (Sep 26, 2016):
It wasn't meant to be a slight. I do thank you for the work.
On Sep 26, 2016 09:48, "Adam Hathcock" notifications@github.com wrote:
@gaffo commented on GitHub (Sep 26, 2016):
Sorry was on a phone and hit send too early, sorry if I came off as entitled or aggressive. I was just mentioning an issue that I also hit.
I didn't mean it as a slight to the author, or the library or the work that I'm getting for free that I do appreciate.
[Removed the rest as it was about another issue]
@TechnikEmpire commented on GitHub (Sep 26, 2016):
@adamhathcock I use this lib, hence why I watch the repo. Great work, really appreciate that you've spent so much of your free time publishing this work. I have not had any issues, but if I did I definitely wouldn't come whining like I paid you for this library. I most certainly wouldn't take the time to write an offensive comment that is longer in characters than the fix is for the issue I found, because I would most definitely just use my non-amateur super skills to type out that fix and submit a pull request.
Didn't mean to slight anyone. Just speaking generally. (Included because apparently declaring no intent to be offensive gives you a free pass to be offensive.)
Sincerely,
A guy who doesn't use bug reports to ask for free customization of a library.
@adamhathcock commented on GitHub (Sep 27, 2016):
As I have some spare time and this should be easy, I did this yesterday to change the API surface for options.
https://github.com/adamhathcock/sharpcompress/pull/174/
@adamhathcock commented on GitHub (Sep 29, 2016):
Hopefully new API is more straight forward https://github.com/adamhathcock/sharpcompress/blob/master/USAGE.md