starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #855] [MERGED] Check crc on tar header #1285

New Issue
Open
opened 2026-01-29 22:19:48 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:19:48 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/855
Author: @Erior
Created: 7/10/2024
Status: ✅ Merged
Merged: 7/12/2024
Merged by: @adamhathcock

Base: master ← Head: feature/Check-tar-crc-on-header

📝 Commits (3)

📊 Changes

3 files changed (+50 additions, -0 deletions)

View changed files

📝 src/SharpCompress/Common/Tar/Headers/TarHeader.cs (+42 -0)
📝 tests/SharpCompress.Test/Tar/TarArchiveTests.cs (+8 -0)
➕ tests/TestArchives/Archives/false.positive.tar (+0 -0)

📄 Description

#837

We could use the CRC for checking validation of the header, however it would seem the Tar.Empty.tar test case is invalid

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/855 **Author:** [@Erior](https://github.com/Erior) **Created:** 7/10/2024 **Status:** ✅ Merged **Merged:** 7/12/2024 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `feature/Check-tar-crc-on-header` --- ### 📝 Commits (3) - [`e42d953`](https://github.com/adamhathcock/sharpcompress/commit/e42d953f47e2339c03e663cdff5015d61873dcea) Check crc on tar header - [`6b88f82`](https://github.com/adamhathcock/sharpcompress/commit/6b88f82656d3fdecd84181f4b098b97632887df4) Handle special case, empty file - [`9515350`](https://github.com/adamhathcock/sharpcompress/commit/9515350f52a40cb54627c029a4fc7b6fe7ffc939) Remove using directive ### 📊 Changes **3 files changed** (+50 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Common/Tar/Headers/TarHeader.cs` (+42 -0) 📝 `tests/SharpCompress.Test/Tar/TarArchiveTests.cs` (+8 -0) ➕ `tests/TestArchives/Archives/false.positive.tar` (+0 -0) </details> ### 📄 Description #837 We could use the CRC for checking validation of the header, however it would seem the Tar.Empty.tar test case is invalid --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:19:48 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1285
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?