starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #876] [MERGED] Restore stream position in ArchiveFactory.IsArchive #1298

New Issue
Closed
opened 2026-01-29 22:19:52 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:19:52 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/876
Author: @Morilli
Created: 10/23/2024
Status: ✅ Merged
Merged: 10/24/2024
Merged by: @adamhathcock

Base: master ← Head: fix-isarchive-stream-seek

📝 Commits (1)

  • 5d62196 Restore stream position in ArchiveFactory.IsArchive

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 src/SharpCompress/Archives/ArchiveFactory.cs (+2 -1)

📄 Description

By resetting the stream position after the archive check, the stream position will be restored to its original value after the method returns.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/876 **Author:** [@Morilli](https://github.com/Morilli) **Created:** 10/23/2024 **Status:** ✅ Merged **Merged:** 10/24/2024 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `fix-isarchive-stream-seek` --- ### 📝 Commits (1) - [`5d62196`](https://github.com/adamhathcock/sharpcompress/commit/5d62196ddee77e44f2e5f590f22c43952f6ab25a) Restore stream position in ArchiveFactory.IsArchive ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Archives/ArchiveFactory.cs` (+2 -1) </details> ### 📄 Description - closes #870 By resetting the stream position after the archive check, the stream position will be restored to its original value after the method returns. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:19:52 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1298
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?