starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #877] [MERGED] Fixed bug in zip time header flags #1300

New Issue
Open
opened 2026-01-29 22:19:52 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:19:52 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/877
Author: @StarkDirewolf
Created: 10/26/2024
Status: ✅ Merged
Merged: 11/1/2024
Merged by: @adamhathcock

Base: master ← Head: master

📝 Commits (2)

  • ab5af40 Fixed bug in zip time header flags, and failing to parse it no longer throws an exception.
  • 0faa176 Sharpier styling

📊 Changes

2 files changed (+36 additions, -9 deletions)

View changed files

📝 src/SharpCompress/Common/Zip/Headers/LocalEntryHeaderExtraFactory.cs (+15 -6)
📝 src/SharpCompress/Common/Zip/ZipEntry.cs (+21 -3)

📄 Description

Parsing the times in the zip headers worked, but the flag check was wrong, so only modified time was ever parsed. Corrected this in a more readable way.

Also stopped exceptions being thrown if there was an issue during this header parsing, returning null values instead.

Remarks have been added to highlight that they return UTC DateTime's, rather than LastModifiedTime which returns a local DateTime.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/877 **Author:** [@StarkDirewolf](https://github.com/StarkDirewolf) **Created:** 10/26/2024 **Status:** ✅ Merged **Merged:** 11/1/2024 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`ab5af40`](https://github.com/adamhathcock/sharpcompress/commit/ab5af409996fdde6ea986c738df9eeeeffdeb6d8) Fixed bug in zip time header flags, and failing to parse it no longer throws an exception. - [`0faa176`](https://github.com/adamhathcock/sharpcompress/commit/0faa176791939ba9b44c594db9b26b35222322a3) Sharpier styling ### 📊 Changes **2 files changed** (+36 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Common/Zip/Headers/LocalEntryHeaderExtraFactory.cs` (+15 -6) 📝 `src/SharpCompress/Common/Zip/ZipEntry.cs` (+21 -3) </details> ### 📄 Description Parsing the times in the zip headers worked, but the flag check was wrong, so only modified time was ever parsed. Corrected this in a more readable way. Also stopped exceptions being thrown if there was an issue during this header parsing, returning null values instead. Remarks have been added to highlight that they return UTC `DateTime`'s, rather than `LastModifiedTime` which returns a local `DateTime`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:19:52 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1300
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?