starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-04 05:25:00 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #889] [MERGED] Make helper classes internal #1306

New Issue
Open
opened 2026-01-29 22:19:53 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:19:53 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/889
Author: @majorro
Created: 1/15/2025
Status: ✅ Merged
Merged: 1/16/2025
Merged by: @adamhathcock

Base: master ← Head: internal-helpers

📝 Commits (4)

📊 Changes

5 files changed (+8 additions, -3 deletions)

View changed files

📝 src/SharpCompress/AssemblyInfo.cs (+4 -0)
📝 src/SharpCompress/NotNullExtensions.cs (+1 -1)
📝 src/SharpCompress/Utility.cs (+1 -2)
📝 tests/SharpCompress.Test/SharpCompress.Test.csproj (+2 -0)
➕ tests/SharpCompress.Test/SharpCompress.Test.snk (+0 -0)

📄 Description

  • Strong assembly name for SharpCompress.Test to make visible internals of main assembly
  • Internal classes of SharpCompress.Helpers

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/889 **Author:** [@majorro](https://github.com/majorro) **Created:** 1/15/2025 **Status:** ✅ Merged **Merged:** 1/16/2025 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `internal-helpers` --- ### 📝 Commits (4) - [`2736b79`](https://github.com/adamhathcock/sharpcompress/commit/2736b790974c1679ef10e60be7446c9305bfe91e) signed test assembly - [`4f4af6e`](https://github.com/adamhathcock/sharpcompress/commit/4f4af6e3fd9c54d5eab56e00eb84b170769fa5f3) make test friend assembly - [`7a1ad66`](https://github.com/adamhathcock/sharpcompress/commit/7a1ad6688a339b3fdcf54ee411f63f56a65e60e6) make helpers internal - [`1159efc`](https://github.com/adamhathcock/sharpcompress/commit/1159efc6cc9c468c90b1a82cf83385301d3b95e2) formatting ### 📊 Changes **5 files changed** (+8 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/AssemblyInfo.cs` (+4 -0) 📝 `src/SharpCompress/NotNullExtensions.cs` (+1 -1) 📝 `src/SharpCompress/Utility.cs` (+1 -2) 📝 `tests/SharpCompress.Test/SharpCompress.Test.csproj` (+2 -0) ➕ `tests/SharpCompress.Test/SharpCompress.Test.snk` (+0 -0) </details> ### 📄 Description - Strong assembly name for `SharpCompress.Test` to make visible internals of main assembly - Internal classes of `SharpCompress.Helpers` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:19:53 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1306
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?