starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-10 21:22:11 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #893] [MERGED] Fix for Rar4 v20 compression. #1316

New Issue
Open
opened 2026-01-29 22:19:56 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:19:56 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/893
Author: @Nanook
Created: 2/7/2025
Status: ✅ Merged
Merged: 2/10/2025
Merged by: @adamhathcock

Base: master ← Head: rar_unpack20

📝 Commits (1)

  • 675cab3 Fix for Rar4 v20 compression.

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/SharpCompress/Compressors/Rar/UnpackV1/Unpack20.cs (+1 -1)

📄 Description

Fix for #216 which I had recently encountered too. This is a small change to CopyString20(), after making it I noticed the same condition already existed in CopyString(). So I'm confident it's good.

The fix has since been tested on over 300 archives that were failing to decompress with the latest SharpCompress and over 250ish were fixed.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/893 **Author:** [@Nanook](https://github.com/Nanook) **Created:** 2/7/2025 **Status:** ✅ Merged **Merged:** 2/10/2025 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `rar_unpack20` --- ### 📝 Commits (1) - [`675cab3`](https://github.com/adamhathcock/sharpcompress/commit/675cab3074fc7cfada98026ce21de48551c9f834) Fix for Rar4 v20 compression. ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Compressors/Rar/UnpackV1/Unpack20.cs` (+1 -1) </details> ### 📄 Description Fix for #216 which I had recently encountered too. This is a small change to CopyString20(), after making it I noticed the same condition already existed in CopyString(). So I'm confident it's good. The fix has since been tested on over 300 archives that were failing to decompress with the latest SharpCompress and over 250ish were fixed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:19:56 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1316
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?