starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-06 05:27:05 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

Unnecessary allocation in ZipWriter? #132

New Issue
Closed
opened 2026-01-29 22:07:07 +00:00 by claunia · 2 comments
claunia commented 2026-01-29 22:07:07 +00:00
Owner
Copy Link

Originally created by @UnknownShadow200 on GitHub (Sep 30, 2016).

Noticed this line in ZipWriter.cs

private readonly PpmdProperties ppmdProperties = new PpmdProperties();

ends up calling Allocator.Start() which allocates a 16 megabyte byte array.

I assume this field is only meant to be assigned when PPMd compression type?

Originally created by @UnknownShadow200 on GitHub (Sep 30, 2016). Noticed this line in ZipWriter.cs ``` CSharp private readonly PpmdProperties ppmdProperties = new PpmdProperties(); ``` ends up calling Allocator.Start() which allocates a 16 megabyte byte array. I assume this field is only meant to be assigned when PPMd compression type?
claunia commented 2026-01-29 22:07:08 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Sep 30, 2016):

Yeah, looks bad. I'll look into fixing that shortly

@adamhathcock commented on GitHub (Sep 30, 2016): Yeah, looks bad. I'll look into fixing that shortly
claunia commented 2026-01-29 22:07:08 +00:00
Author
Owner
Copy Link

@adamhathcock commented on GitHub (Oct 3, 2016):

https://www.nuget.org/packages/sharpcompress/0.13.1

@adamhathcock commented on GitHub (Oct 3, 2016): https://www.nuget.org/packages/sharpcompress/0.13.1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#132
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?