starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-08 21:21:57 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #900] [MERGED] make WriteToDirectory functions use ExtractAllEntries #1326

New Issue
Open
opened 2026-01-29 22:19:59 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:19:59 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/900
Author: @Morilli
Created: 2/28/2025
Status: ✅ Merged
Merged: 3/3/2025
Merged by: @adamhathcock

Base: master ← Head: WriteToDirectory-reader

📝 Commits (1)

  • 5450b9a make WriteToDirectory functions use ExtractAllEntries

📊 Changes

2 files changed (+4 additions, -8 deletions)

View changed files

📝 src/SharpCompress/Archives/ArchiveFactory.cs (+1 -4)
📝 src/SharpCompress/Archives/IArchiveExtensions.cs (+3 -4)

📄 Description

  • closes #710 and possibly some other related ones

For extracting files from solid archives calling ExtractAllEntries is required to get acceptable extraction performance and should therefore always be called.

Clearly people are not aware of this function, and the base library not using it is not helping. Perhaps it should be mentioned in the USAGE.md?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/900 **Author:** [@Morilli](https://github.com/Morilli) **Created:** 2/28/2025 **Status:** ✅ Merged **Merged:** 3/3/2025 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `WriteToDirectory-reader` --- ### 📝 Commits (1) - [`5450b9a`](https://github.com/adamhathcock/sharpcompress/commit/5450b9a700c18dac980a91ec8a11552cdd939508) make WriteToDirectory functions use ExtractAllEntries ### 📊 Changes **2 files changed** (+4 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Archives/ArchiveFactory.cs` (+1 -4) 📝 `src/SharpCompress/Archives/IArchiveExtensions.cs` (+3 -4) </details> ### 📄 Description - closes #710 and possibly some other related ones For extracting files from solid archives calling `ExtractAllEntries` is required to get acceptable extraction performance and should therefore always be called. Clearly people are not aware of this function, and the base library not using it is not helping. Perhaps it should be mentioned in the `USAGE.md`? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:19:59 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1326
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?