starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #916] [MERGED] Implement multipart rar handling for ExtractAllEntries #1344

New Issue
Closed
opened 2026-01-29 22:20:05 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:20:05 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/916
Author: @Morilli
Created: 5/14/2025
Status: ✅ Merged
Merged: 5/14/2025
Merged by: @adamhathcock

Base: master ← Head: rar-multipart-reader

📝 Commits (5)

  • 1a452ac implement ExtractAllEntries for multipart rar files
  • c0cd998 add failing test
  • a3570a5 fix AbstractReader.Skip for multipart files
  • 7989ab2 modify now-broken test
  • 6e51967 format

📊 Changes

3 files changed (+45 additions, -36 deletions)

View changed files

📝 src/SharpCompress/Archives/Rar/RarArchive.cs (+10 -0)
📝 src/SharpCompress/Readers/AbstractReader.cs (+1 -1)
📝 tests/SharpCompress.Test/Rar/RarReaderTests.cs (+34 -35)

📄 Description

One side-effect of the changes here is that skipping over encrypted entries for which the password is not known in a multipart rar file using the reader interface no longer works.

However reading those entries does not work because it isn't currently implemented, and the skipping was bad as well because it would fail to skip all file parts and returned after skipping the first part only, so I think it is fair to remove this functionality.
It could be implemented properly but I think it would take some effort to extract the needed information and perhaps need additional interface methods.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/916 **Author:** [@Morilli](https://github.com/Morilli) **Created:** 5/14/2025 **Status:** ✅ Merged **Merged:** 5/14/2025 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `rar-multipart-reader` --- ### 📝 Commits (5) - [`1a452ac`](https://github.com/adamhathcock/sharpcompress/commit/1a452acd1c112d1f5d496d61820455071f163d2c) implement ExtractAllEntries for multipart rar files - [`c0cd998`](https://github.com/adamhathcock/sharpcompress/commit/c0cd9988361218a5ea0d9ec0ed6b47ea6733b74b) add failing test - [`a3570a5`](https://github.com/adamhathcock/sharpcompress/commit/a3570a568df1ab093207ac0737ef84e049f4930d) fix AbstractReader.Skip for multipart files - [`7989ab2`](https://github.com/adamhathcock/sharpcompress/commit/7989ab2e281cc760c712e5b4ce26f748583b1fcd) modify now-broken test - [`6e51967`](https://github.com/adamhathcock/sharpcompress/commit/6e51967993df5298ec2ffce3978d35366a8657d4) format ### 📊 Changes **3 files changed** (+45 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Archives/Rar/RarArchive.cs` (+10 -0) 📝 `src/SharpCompress/Readers/AbstractReader.cs` (+1 -1) 📝 `tests/SharpCompress.Test/Rar/RarReaderTests.cs` (+34 -35) </details> ### 📄 Description - closes #915. One side-effect of the changes here is that *skipping over encrypted entries for which the password is not known in a multipart rar file using the reader interface* no longer works. However *reading* those entries does not work because it isn't currently implemented, and the skipping was bad as well because it would fail to skip all file parts and returned after skipping the first part only, so I think it is fair to remove this functionality. It could be implemented properly but I think it would take some effort to extract the needed information and perhaps need additional interface methods. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:20:05 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1344
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?