starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #921] [MERGED] Fix volume FileName property potentially missing #1348

New Issue
Open
opened 2026-01-29 22:20:07 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:20:07 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/921
Author: @Morilli
Created: 7/6/2025
Status: ✅ Merged
Merged: 7/7/2025
Merged by: @adamhathcock

Base: master ← Head: fix-volume-filename

📝 Commits (1)

  • aa9cf19 Fix volume FileName property potentially missing

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 src/SharpCompress/Common/Volume.cs (+3 -1)

📄 Description

If the ReaderOptions has LeaveStreamOpen set (which is set to true by default), the stream used to report a volume's FileName was a NonDisposingStream instead of the originally passed in stream, which never worked.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/921 **Author:** [@Morilli](https://github.com/Morilli) **Created:** 7/6/2025 **Status:** ✅ Merged **Merged:** 7/7/2025 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `fix-volume-filename` --- ### 📝 Commits (1) - [`aa9cf19`](https://github.com/adamhathcock/sharpcompress/commit/aa9cf195a5c51555b34d8b4b9577a559c4e13e5f) Fix volume FileName property potentially missing ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Common/Volume.cs` (+3 -1) </details> ### 📄 Description - closes #920 If the `ReaderOptions` has `LeaveStreamOpen` set (which is set to true by default), the stream used to report a volume's `FileName` was a `NonDisposingStream` instead of the originally passed in stream, which never worked. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:20:07 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1348
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?