starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #924] [MERGED] Fix 7-zip solid archive detection #1349

New Issue
Closed
opened 2026-01-29 22:20:07 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:20:07 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/924
Author: @Morilli
Created: 7/13/2025
Status: ✅ Merged
Merged: 7/14/2025
Merged by: @adamhathcock

Base: master ← Head: 7zip-1block-solid-archive

📝 Commits (2)

  • 8de30db add failing test
  • c489e5a fix SevenZipArchive solid detection

📊 Changes

3 files changed (+23 additions, -1 deletions)

View changed files

📝 src/SharpCompress/Archives/SevenZip/SevenZipArchive.cs (+4 -1)
📝 tests/SharpCompress.Test/SevenZip/SevenZipArchiveTests.cs (+19 -0)
➕ tests/TestArchives/Archives/7Zip.solid.1block.7z (+0 -0)

📄 Description

  • closes #923 and fixes IsSolid logic in general

For some reason 7-zip doesn't like to create 1-block solid archives so I had to create a new 7z file with one less file included than the 7Zip.solid.7z to get a solid archive with only one block.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/924 **Author:** [@Morilli](https://github.com/Morilli) **Created:** 7/13/2025 **Status:** ✅ Merged **Merged:** 7/14/2025 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `7zip-1block-solid-archive` --- ### 📝 Commits (2) - [`8de30db`](https://github.com/adamhathcock/sharpcompress/commit/8de30db7f98c4e47c2e5d2a5ad4f7e5aa7c15080) add failing test - [`c489e5a`](https://github.com/adamhathcock/sharpcompress/commit/c489e5a59be803470110f0d1927301a148de535b) fix SevenZipArchive solid detection ### 📊 Changes **3 files changed** (+23 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Archives/SevenZip/SevenZipArchive.cs` (+4 -1) 📝 `tests/SharpCompress.Test/SevenZip/SevenZipArchiveTests.cs` (+19 -0) ➕ `tests/TestArchives/Archives/7Zip.solid.1block.7z` (+0 -0) </details> ### 📄 Description - closes #923 and fixes `IsSolid` logic in general For some reason 7-zip doesn't like to create 1-block solid archives so I had to create a new 7z file with one less file included than the `7Zip.solid.7z` to get a solid archive with only one block. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:20:07 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1349
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?