starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

Null reference when disposing a Volume class #135

New Issue
Open
opened 2026-01-29 22:07:13 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:07:13 +00:00
Owner
Copy Link

Originally created by @JasonBro on GitHub (Oct 3, 2016).

There's a new bit of code in the SharpCompress.Common.Volume class that causes a null exception when ReaderOptions is null (which it is by default).

Workround: Add a ReaderOptions in the Open(Stream, ReaderOptions) call.

    public void Dispose()
    {
        if (!ReaderOptions.LeaveStreamOpen && !disposed)
        {
            actualStream.Dispose();
            disposed = true;
        }
    }
Originally created by @JasonBro on GitHub (Oct 3, 2016). There's a new bit of code in the SharpCompress.Common.Volume class that causes a null exception when ReaderOptions is null (which it is by default). Workround: Add a ReaderOptions in the Open(Stream, ReaderOptions) call. ``` public void Dispose() { if (!ReaderOptions.LeaveStreamOpen && !disposed) { actualStream.Dispose(); disposed = true; } } ```
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#135
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?