[PR #934] [MERGED] Zip ZStandard Writing with tests. Level support. #1357

New Issue

Open

opened 2026-01-29 22:20:09 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 22:20:09 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/934
Author: @Nanook
Created: 7/24/2025
Status: ✅ Merged
Merged: 7/24/2025
Merged by: @adamhathcock

Base: master ← Head: feature/zstd_zip_writing

---

📝 Commits (8)

• c5de3d8 Zip ZStandard Writing with tests. Level support.
• e9dd413 CSharpier formatting.
• b7f5b36 Update src/SharpCompress/Writers/Zip/ZipWriter.cs
• 5cbb31c Update tests/SharpCompress.Test/Zip/TestPseudoTextStream.cs
• d15816f Update tests/SharpCompress.Test/Zip/TestPseudoTextStream.cs
• ae311ea Update tests/SharpCompress.Test/Zip/TestPseudoTextStream.cs
• 7769435 CSharpier fixes after copilot tweaks.
• 8a0152f Fixed up test issue after copilot "fixes" :S.

📊 Changes

13 files changed (+681 additions, -28 deletions)

View changed files

📝 src/SharpCompress/Common/CompressionType.cs (+1 -0)
📝 src/SharpCompress/Common/Zip/ZipCompressionMethod.cs (+1 -1)
📝 src/SharpCompress/Common/Zip/ZipEntry.cs (+1 -0)
📝 src/SharpCompress/Common/Zip/ZipFilePart.cs (+1 -1)
📝 src/SharpCompress/Writers/GZip/GZipWriter.cs (+1 -1)
📝 src/SharpCompress/Writers/GZip/GZipWriterOptions.cs (+4 -10)
📝 src/SharpCompress/Writers/WriterOptions.cs (+30 -2)
📝 src/SharpCompress/Writers/Zip/ZipWriter.cs (+15 -6)
📝 src/SharpCompress/Writers/Zip/ZipWriterEntryOptions.cs (+27 -2)
📝 src/SharpCompress/Writers/Zip/ZipWriterOptions.cs (+48 -5)
📝 tests/SharpCompress.Test/ArchiveTests.cs (+218 -0)
➕ tests/SharpCompress.Test/Zip/TestPseudoTextStream.cs (+99 -0)
➕ tests/SharpCompress.Test/Zip/ZipMemoryArchiveWithCrcTests.cs (+235 -0)

📄 Description

Add ZStandard compression support and enhanced Zip creation tests

This PR introduces ZStandard compression support for ZIP archives with configurable compression levels, along with comprehensive test coverage for various compression algorithms and performance validation.

Key Changes:
• ZStandard ZIP Support: Added ZStandard compression capability with full compression level control
• Enhanced CompressionLevel API: Updated WriterOptions.CompressionLevel to use int type, enabling support for various compression algorithms with different level ranges (e.g., ZStandard levels 1-22, Deflate levels 1-9)
• Backward Compatibility: All changes maintain backward compatibility with existing APIs

New Test Coverage:
• Comprehensive Zip Creation Tests: Added extensive test suite using a deterministic pseudo-text stream generator
• Multi-Algorithm Testing: Tests cover Deflate, ZStandard, BZip2, LZMA, and uncompressed scenarios
• Compression Level Validation: Validates compression effectiveness across different levels with realistic ratio expectations
• Large File Testing: Tests with multi-megabyte files to exercise IStackStream buffering and rewind capabilities more thoroughly
• CRC32 Verification: All tests include end-to-end CRC32 validation to ensure data integrity

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/934 **Author:** [@Nanook](https://github.com/Nanook) **Created:** 7/24/2025 **Status:** ✅ Merged **Merged:** 7/24/2025 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `feature/zstd_zip_writing` --- ### 📝 Commits (8) - [`c5de3d8`](https://github.com/adamhathcock/sharpcompress/commit/c5de3d8cc17b6db581a250ed2b6818f7abc23dce) Zip ZStandard Writing with tests. Level support. - [`e9dd413`](https://github.com/adamhathcock/sharpcompress/commit/e9dd413de61ff8f77615318bea4b814ad3327c7e) CSharpier formatting. - [`b7f5b36`](https://github.com/adamhathcock/sharpcompress/commit/b7f5b36f2b488ac2fb418ff5bdf04bd17e1c22bb) Update src/SharpCompress/Writers/Zip/ZipWriter.cs - [`5cbb31c`](https://github.com/adamhathcock/sharpcompress/commit/5cbb31c559ff6eba9b8dec4dd85964b15c8f1f67) Update tests/SharpCompress.Test/Zip/TestPseudoTextStream.cs - [`d15816f`](https://github.com/adamhathcock/sharpcompress/commit/d15816f16244b451e89510c686fef150939604a6) Update tests/SharpCompress.Test/Zip/TestPseudoTextStream.cs - [`ae311ea`](https://github.com/adamhathcock/sharpcompress/commit/ae311ea66e4f8779d494bbf1cf1c893498199f34) Update tests/SharpCompress.Test/Zip/TestPseudoTextStream.cs - [`7769435`](https://github.com/adamhathcock/sharpcompress/commit/7769435fc828c67d9ddd4bb312839c9448bd0f2d) CSharpier fixes after copilot tweaks. - [`8a0152f`](https://github.com/adamhathcock/sharpcompress/commit/8a0152fe7c989acc6f71ee1f4bb7745d6b47a2ff) Fixed up test issue after copilot "fixes" :S. ### 📊 Changes **13 files changed** (+681 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Common/CompressionType.cs` (+1 -0) 📝 `src/SharpCompress/Common/Zip/ZipCompressionMethod.cs` (+1 -1) 📝 `src/SharpCompress/Common/Zip/ZipEntry.cs` (+1 -0) 📝 `src/SharpCompress/Common/Zip/ZipFilePart.cs` (+1 -1) 📝 `src/SharpCompress/Writers/GZip/GZipWriter.cs` (+1 -1) 📝 `src/SharpCompress/Writers/GZip/GZipWriterOptions.cs` (+4 -10) 📝 `src/SharpCompress/Writers/WriterOptions.cs` (+30 -2) 📝 `src/SharpCompress/Writers/Zip/ZipWriter.cs` (+15 -6) 📝 `src/SharpCompress/Writers/Zip/ZipWriterEntryOptions.cs` (+27 -2) 📝 `src/SharpCompress/Writers/Zip/ZipWriterOptions.cs` (+48 -5) 📝 `tests/SharpCompress.Test/ArchiveTests.cs` (+218 -0) ➕ `tests/SharpCompress.Test/Zip/TestPseudoTextStream.cs` (+99 -0) ➕ `tests/SharpCompress.Test/Zip/ZipMemoryArchiveWithCrcTests.cs` (+235 -0) </details> ### 📄 Description Add ZStandard compression support and enhanced Zip creation tests This PR introduces ZStandard compression support for ZIP archives with configurable compression levels, along with comprehensive test coverage for various compression algorithms and performance validation. **Key Changes:** • ZStandard ZIP Support: Added ZStandard compression capability with full compression level control • Enhanced CompressionLevel API: Updated WriterOptions.CompressionLevel to use int type, enabling support for various compression algorithms with different level ranges (e.g., ZStandard levels 1-22, Deflate levels 1-9) • Backward Compatibility: All changes maintain backward compatibility with existing APIs **New Test Coverage:** • Comprehensive Zip Creation Tests: Added extensive test suite using a deterministic pseudo-text stream generator • Multi-Algorithm Testing: Tests cover Deflate, ZStandard, BZip2, LZMA, and uncompressed scenarios • Compression Level Validation: Validates compression effectiveness across different levels with realistic ratio expectations • Large File Testing: Tests with multi-megabyte files to exercise IStackStream buffering and rewind capabilities more thoroughly • CRC32 Verification: All tests include end-to-end CRC32 validation to ensure data integrity --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 22:20:09 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

adam/fix-editorconfig-errors

adam/add-alternate-compressions

copilot/consolidate-readfully-readexact-logic

adam/make-nullable

copilot/fix-openentrystreamasync-memory-issue

release

adam/more-explode-async

copilot/fix-infinite-loop-rar-archive

adam/data-descriptor-fix

adam/fix-tests-with-proper-rewind

copilot/fix-data-descriptor-stream-bug

adam/lmza-investigation

adam/create-rar-async

adam/async-rar2

copilot/support-multi-threading-path

copilot/sub-pr-1132-again

adam/memory-perf

copilot/add-performance-benchmarking

copilot/sub-pr-1121

copilot/add-password-support-zip-files

copilot/add-so-optimized-zip-support

adam/rar-async-only

copilot/add-buffered-stream-async-read

copilot/sub-pr-1076

copilot/fix-decompression-exception

copilot/fix-archivefactory-issue

copilot/rationalize-sourcestream-volumes

adam/open-async

copilot/add-ace-archive-support

copilot/sub-pr-1040-again

adam/more-async-3

copilot/fix-tararchive-incomplete-iteration

adam/multi-threaded

copilot/sub-pr-1040

adam/awesome-copilot

copilot/fix-ziparchive-extraction-issue

copilot/fix-tararchive-open-crash

copilot/fix-tar-xz-file-reading-issue

copilot/setup-copilot-instructions

copilot/fix-decompression-performance-issue

copilot/convert-stream-access-to-async

adam/enable-agent

adam/async-deflate

adam/async-rar

adam/more-cleanup

adam/zstd

async-2

zstandard

net461-tests

dmg

async

build-netcore3

recycle-memory-stream

presentation

pax

netcore2

zip_encryption

dotnet-tool

tar_redux

native_zlib

Issue-197

system_buffers

TarNames

7zip_sfx

portable_crypto

WinRT

new_7zip

0.45.1

0.45.0

0.44.5

0.44.4

0.44.3

0.44.2

0.44.1

0.44.0

0.43.0

0.42.1

0.42.0

0.41.0

0.40.0

0.39.0

0.38.0

0.37.2

0.37.1

0.37.0

0.36.0

0.35.0

0.34.2

0.34.1

0.34.0

0.33.0

0.32.2

0.32.1

0.32

0.31

0.30.1

0.30

0.29

0.29.0

0.28.3

0.28.2

0.28.1

0.28

0.27.1

0.27

0.26

0.25.1

0.25

0.24

0.23

0.22

0.21.1

0.21

0.21.0

0.20.0

0.19.2

0.19.1

0.19

0.18.2

0.18.1

0.18

0.17.1

0.17.0

0.16.2

0.16.1

0.16.0

0.15.2

0.15.1

0.15.0

0.14.1

0.14.0

0.13.1

0.13.0

0.12.4

0.12.3

0.12.2

0.12.1

0.12.0

0.11.6

0.11.5

0.11.4

0.11.3

0.11.2

0.11.1

0.11

0.10.3

0.10.2

0.10.1.3

0.10.1.2

0.10.1.1

0.10.1

0.10

0.9

Labels

Clear labels

bug

duplicate

enhancement

feedback requested

not bug

pull-request

Mirrored from GitHub Pull Request

question

up for grabs

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/sharpcompress#1357