starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #949] [CLOSED] Move ZstdSharp into SharpCompress #1364

New Issue
Closed
opened 2026-01-29 22:20:11 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:20:11 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/949
Author: @adamhathcock
Created: 10/13/2025
Status: ❌ Closed

Base: master ← Head: adam/zstd

📝 Commits (7)

  • 5b5336f add first pass of zstdsharp into library. Full fat framework doesn't compile. Marked lib as not CLS compliant again
  • 999af80 add more non legacy stuff
  • b545973 stuff compiles now
  • 0a7ffd0 ran formatting
  • 906baf1 fix namespaces
  • ee2cbc8 fmt
  • b010cce Merge branch 'master' into adam/zstd

📊 Changes

254 files changed (+57493 additions, -1873 deletions)

View changed files

📝 Directory.Packages.props (+2 -2)
📝 src/SharpCompress/AssemblyInfo.cs (+1 -1)
📝 src/SharpCompress/Common/Arc/ArcEntry.cs (+29 -30)
📝 src/SharpCompress/Common/Arc/ArcEntryHeader.cs (+57 -58)
📝 src/SharpCompress/Common/Arc/ArcFilePart.cs (+41 -49)
📝 src/SharpCompress/Common/Arc/ArcVolume.cs (+5 -6)
📝 src/SharpCompress/Common/Zip/ZipFilePart.cs (+1 -1)
📝 src/SharpCompress/Compressors/Filters/DeltaFilter.cs (+24 -25)
📝 src/SharpCompress/Compressors/LZMA/Registry.cs (+1 -1)
📝 src/SharpCompress/Compressors/Lzw/LzwConstants.cs (+50 -51)
📝 src/SharpCompress/Compressors/Lzw/LzwStream.cs (+509 -512)
📝 src/SharpCompress/Compressors/RLE90/RLE.cs (+34 -35)
📝 src/SharpCompress/Compressors/RLE90/RunLength90Stream.cs (+59 -60)
📝 src/SharpCompress/Compressors/Shrink/BitStream.cs (+61 -62)
📝 src/SharpCompress/Compressors/Shrink/HwUnshrink.cs (+331 -332)
📝 src/SharpCompress/Compressors/Squeezed/SqueezedStream.cs (+99 -100)
➕ src/SharpCompress/Compressors/ZStandard/BitOperations.cs (+311 -0)
➕ src/SharpCompress/Compressors/ZStandard/CompressionStream.cs (+301 -0)
➕ src/SharpCompress/Compressors/ZStandard/Compressor.cs (+204 -0)
➕ src/SharpCompress/Compressors/ZStandard/Constants.cs (+8 -0)

...and 80 more files

📄 Description

I think the authors have little interest in this: https://github.com/oleg-st/ZstdSharp/issues/36

The biggest hurdle found so far is that there is a lot of unsafe/native usage that is probably incompatible with AOT. I know work was done to make everything CLSCompliant.

I'm ignoring big issues but might also rethink what targets there are. The legacy framework targets are slowing things down too.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/949 **Author:** [@adamhathcock](https://github.com/adamhathcock) **Created:** 10/13/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `adam/zstd` --- ### 📝 Commits (7) - [`5b5336f`](https://github.com/adamhathcock/sharpcompress/commit/5b5336f456d6f67c380a3e4f857e31dbca382dec) add first pass of zstdsharp into library. Full fat framework doesn't compile. Marked lib as not CLS compliant again - [`999af80`](https://github.com/adamhathcock/sharpcompress/commit/999af800afaa6850d2cf6b8d12894ab0572737e9) add more non legacy stuff - [`b545973`](https://github.com/adamhathcock/sharpcompress/commit/b545973c55df4f5b2cc4e7a0a3892e035a486f82) stuff compiles now - [`0a7ffd0`](https://github.com/adamhathcock/sharpcompress/commit/0a7ffd003b160759d8f4f96fbf45763aaf2c06c2) ran formatting - [`906baf1`](https://github.com/adamhathcock/sharpcompress/commit/906baf18d253ac682a6621d860faa41917dfe968) fix namespaces - [`ee2cbc8`](https://github.com/adamhathcock/sharpcompress/commit/ee2cbc8051bff0f4ea92cb1fc9aaecb406d4f145) fmt - [`b010cce`](https://github.com/adamhathcock/sharpcompress/commit/b010cce1ca99bd36e966365dd93f16222872fa3c) Merge branch 'master' into adam/zstd ### 📊 Changes **254 files changed** (+57493 additions, -1873 deletions) <details> <summary>View changed files</summary> 📝 `Directory.Packages.props` (+2 -2) 📝 `src/SharpCompress/AssemblyInfo.cs` (+1 -1) 📝 `src/SharpCompress/Common/Arc/ArcEntry.cs` (+29 -30) 📝 `src/SharpCompress/Common/Arc/ArcEntryHeader.cs` (+57 -58) 📝 `src/SharpCompress/Common/Arc/ArcFilePart.cs` (+41 -49) 📝 `src/SharpCompress/Common/Arc/ArcVolume.cs` (+5 -6) 📝 `src/SharpCompress/Common/Zip/ZipFilePart.cs` (+1 -1) 📝 `src/SharpCompress/Compressors/Filters/DeltaFilter.cs` (+24 -25) 📝 `src/SharpCompress/Compressors/LZMA/Registry.cs` (+1 -1) 📝 `src/SharpCompress/Compressors/Lzw/LzwConstants.cs` (+50 -51) 📝 `src/SharpCompress/Compressors/Lzw/LzwStream.cs` (+509 -512) 📝 `src/SharpCompress/Compressors/RLE90/RLE.cs` (+34 -35) 📝 `src/SharpCompress/Compressors/RLE90/RunLength90Stream.cs` (+59 -60) 📝 `src/SharpCompress/Compressors/Shrink/BitStream.cs` (+61 -62) 📝 `src/SharpCompress/Compressors/Shrink/HwUnshrink.cs` (+331 -332) 📝 `src/SharpCompress/Compressors/Squeezed/SqueezedStream.cs` (+99 -100) ➕ `src/SharpCompress/Compressors/ZStandard/BitOperations.cs` (+311 -0) ➕ `src/SharpCompress/Compressors/ZStandard/CompressionStream.cs` (+301 -0) ➕ `src/SharpCompress/Compressors/ZStandard/Compressor.cs` (+204 -0) ➕ `src/SharpCompress/Compressors/ZStandard/Constants.cs` (+8 -0) _...and 80 more files_ </details> ### 📄 Description I think the authors have little interest in this: https://github.com/oleg-st/ZstdSharp/issues/36 The biggest hurdle found so far is that there is a lot of unsafe/native usage that is probably incompatible with AOT. I know work was done to make everything CLSCompliant. I'm ignoring big issues but might also rethink what targets there are. The legacy framework targets are slowing things down too. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:20:11 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1364
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?