starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-13 13:35:28 +00:00
Code Issues 975 Packages Projects Releases 23 Wiki Activity

[PR #958] [CLOSED] More cleanup #1378

New Issue
Closed
opened 2026-01-29 22:20:16 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:20:16 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/958
Author: @adamhathcock
Created: 10/14/2025
Status: ❌ Closed

Base: master ← Head: adam/more-cleanup

📝 Commits (10+)

📊 Changes

169 files changed (+2870 additions, -2941 deletions)

View changed files

📝 .editorconfig (+275 -460)
📝 Directory.Build.props (+30 -7)
📝 build/Program.cs (+1 -1)
📝 src/SharpCompress/Algorithms/Adler32.cs (+3 -4)
📝 src/SharpCompress/Archives/AbstractArchive.cs (+2 -2)
📝 src/SharpCompress/Archives/AbstractWritableArchive.cs (+3 -3)
📝 src/SharpCompress/Archives/ArchiveVolumeFactory.cs (+5 -0)
📝 src/SharpCompress/Archives/AutoArchiveFactory.cs (+1 -1)
📝 src/SharpCompress/Archives/GZip/GZipArchive.cs (+1 -1)
📝 src/SharpCompress/Archives/GZip/GZipArchiveEntry.cs (+4 -1)
📝 src/SharpCompress/Archives/IArchiveExtensions.cs (+0 -1)
📝 src/SharpCompress/Archives/IWriteableArchiveFactory.cs (+0 -14)
📝 src/SharpCompress/Archives/Rar/FileInfoRarFilePart.cs (+4 -1)
📝 src/SharpCompress/Archives/Rar/RarArchive.cs (+2 -2)
📝 src/SharpCompress/Archives/Rar/RarArchiveEntry.cs (+3 -1)
📝 src/SharpCompress/Archives/Rar/RarArchiveEntryFactory.cs (+1 -1)
📝 src/SharpCompress/Archives/Rar/RarArchiveVolumeFactory.cs (+8 -0)
📝 src/SharpCompress/Archives/SevenZip/SevenZipArchive.cs (+11 -6)
📝 src/SharpCompress/Archives/SevenZip/SevenZipArchiveEntry.cs (+4 -1)
📝 src/SharpCompress/Archives/Tar/TarArchiveEntry.cs (+4 -1)

...and 80 more files

📄 Description

  • file scoped namespaces
  • add braces
  • added better editorconfig and rejiggered build /csproj (added lots of exceptions for now)
  • fixed build and tests

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/958 **Author:** [@adamhathcock](https://github.com/adamhathcock) **Created:** 10/14/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `adam/more-cleanup` --- ### 📝 Commits (10+) - [`6de3735`](https://github.com/adamhathcock/sharpcompress/commit/6de3735f0ff060a40cd6aaa719abc599d9af82fd) more file scoped namespaces - [`8b9d8c9`](https://github.com/adamhathcock/sharpcompress/commit/8b9d8c9b065aea2ed2ccf4338755987495ab40ec) formatting - [`30fe351`](https://github.com/adamhathcock/sharpcompress/commit/30fe3516cb6f7989f3fd0915afd75d5d0bc638f3) add braces - [`fedafd5`](https://github.com/adamhathcock/sharpcompress/commit/fedafd59503b53f4ad497e92272ea6cef4543ec9) start new editorconfig: file namespaces and use collection expressions - [`37be684`](https://github.com/adamhathcock/sharpcompress/commit/37be684d64d13bf1ff164a943ef510941cfd4d53) another round of fixes - [`4ac74b6`](https://github.com/adamhathcock/sharpcompress/commit/4ac74b61a303c8cc22a9f6cab533f57bc02acbf0) more - [`85c1e93`](https://github.com/adamhathcock/sharpcompress/commit/85c1e93183e83564df162b45fbd19ed4493795a6) disable styling checks but fix build errors - [`8b5e878`](https://github.com/adamhathcock/sharpcompress/commit/8b5e87837dd7ae782cef49851316c5329ddd5977) fix a test - [`bc7a968`](https://github.com/adamhathcock/sharpcompress/commit/bc7a9684ba6eb7ad3c0ed5c65a60728e221e37d2) fmt - [`c4597fd`](https://github.com/adamhathcock/sharpcompress/commit/c4597fd15677b253714103e3081ddb5435854ab9) fix spacing ### 📊 Changes **169 files changed** (+2870 additions, -2941 deletions) <details> <summary>View changed files</summary> 📝 `.editorconfig` (+275 -460) 📝 `Directory.Build.props` (+30 -7) 📝 `build/Program.cs` (+1 -1) 📝 `src/SharpCompress/Algorithms/Adler32.cs` (+3 -4) 📝 `src/SharpCompress/Archives/AbstractArchive.cs` (+2 -2) 📝 `src/SharpCompress/Archives/AbstractWritableArchive.cs` (+3 -3) 📝 `src/SharpCompress/Archives/ArchiveVolumeFactory.cs` (+5 -0) 📝 `src/SharpCompress/Archives/AutoArchiveFactory.cs` (+1 -1) 📝 `src/SharpCompress/Archives/GZip/GZipArchive.cs` (+1 -1) 📝 `src/SharpCompress/Archives/GZip/GZipArchiveEntry.cs` (+4 -1) 📝 `src/SharpCompress/Archives/IArchiveExtensions.cs` (+0 -1) 📝 `src/SharpCompress/Archives/IWriteableArchiveFactory.cs` (+0 -14) 📝 `src/SharpCompress/Archives/Rar/FileInfoRarFilePart.cs` (+4 -1) 📝 `src/SharpCompress/Archives/Rar/RarArchive.cs` (+2 -2) 📝 `src/SharpCompress/Archives/Rar/RarArchiveEntry.cs` (+3 -1) 📝 `src/SharpCompress/Archives/Rar/RarArchiveEntryFactory.cs` (+1 -1) 📝 `src/SharpCompress/Archives/Rar/RarArchiveVolumeFactory.cs` (+8 -0) 📝 `src/SharpCompress/Archives/SevenZip/SevenZipArchive.cs` (+11 -6) 📝 `src/SharpCompress/Archives/SevenZip/SevenZipArchiveEntry.cs` (+4 -1) 📝 `src/SharpCompress/Archives/Tar/TarArchiveEntry.cs` (+4 -1) _...and 80 more files_ </details> ### 📄 Description - file scoped namespaces - add braces - added better editorconfig and rejiggered build /csproj (added lots of exceptions for now) - fixed build and tests --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:20:16 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1378
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?