starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #966] [MERGED] Remove a dynamically created stackalloc #1383

New Issue
Closed
opened 2026-01-29 22:20:17 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:20:17 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/966
Author: @adamhathcock
Created: 10/22/2025
Status: ✅ Merged
Merged: 10/22/2025
Merged by: @adamhathcock

Base: master ← Head: adam/reduce-stackalloc

📝 Commits (4)

  • 6de738f reduce dynamic stackallocs in unpackv1
  • 01021e1 remove some extra stackallocs
  • 36c06c4 ugh, this is used because it shadows a field
  • 74e27c0 fix the span length

📊 Changes

2 files changed (+25 additions, -15 deletions)

View changed files

📝 src/SharpCompress/Compressors/Rar/UnpackV1/Unpack.cs (+21 -12)
📝 src/SharpCompress/Compressors/Rar/VM/RarVM.cs (+4 -3)

📄 Description

Hopefully there's no more that will blow out the stack.

Fixes https://github.com/adamhathcock/sharpcompress/issues/965

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/966 **Author:** [@adamhathcock](https://github.com/adamhathcock) **Created:** 10/22/2025 **Status:** ✅ Merged **Merged:** 10/22/2025 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `adam/reduce-stackalloc` --- ### 📝 Commits (4) - [`6de738f`](https://github.com/adamhathcock/sharpcompress/commit/6de738ff17da4d44c0d7ba32039dfa1f4d5d0622) reduce dynamic stackallocs in unpackv1 - [`01021e1`](https://github.com/adamhathcock/sharpcompress/commit/01021e102b9bd12e13355e66f9f912cbc871315c) remove some extra stackallocs - [`36c06c4`](https://github.com/adamhathcock/sharpcompress/commit/36c06c4089c8df94d40566ae866476bd8159ccc0) ugh, this is used because it shadows a field - [`74e27c0`](https://github.com/adamhathcock/sharpcompress/commit/74e27c028eadc73222f863c6cf1d72fb55af1b58) fix the span length ### 📊 Changes **2 files changed** (+25 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Compressors/Rar/UnpackV1/Unpack.cs` (+21 -12) 📝 `src/SharpCompress/Compressors/Rar/VM/RarVM.cs` (+4 -3) </details> ### 📄 Description Hopefully there's no more that will blow out the stack. Fixes https://github.com/adamhathcock/sharpcompress/issues/965 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:20:17 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1383
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?