[PR #967] [MERGED] Reduce custom utilities for arrays/bytes #1386

New Issue

Closed

opened 2026-01-29 22:20:19 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 22:20:19 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/967
Author: @adamhathcock
Created: 10/22/2025
Status: ✅ Merged
Merged: 10/22/2025
Merged by: @adamhathcock

Base: master ← Head: adam/reduce-custom-utilities

---

📝 Commits (10+)

• e0d6cd9 Try to reduce custom functions for array/byte management
• c823aca optimize ReadFully and Skip
• 084fe72 Consolidate not null
• d8797b6 remove do while
• 62bee15 fmt
• 249b8a9 add AI generated tests
• 513cd4f some AI suggestions
• 83917d4 Merge remote-tracking branch 'origin/master' into adam/reduce-custom-utilities
• a1dfa3d xplat tests for path characters
• 00df8e9 add windows only compile constant

📊 Changes

28 files changed (+894 additions, -246 deletions)

View changed files

📝 Directory.Packages.props (+0 -1)
📝 src/SharpCompress/Archives/ArchiveFactory.cs (+11 -11)
📝 src/SharpCompress/Archives/GZip/GZipArchive.cs (+5 -5)
📝 src/SharpCompress/Archives/IArchiveEntryExtensions.cs (+1 -1)
📝 src/SharpCompress/Archives/Rar/RarArchive.cs (+5 -5)
📝 src/SharpCompress/Archives/SevenZip/SevenZipArchive.cs (+5 -5)
📝 src/SharpCompress/Archives/Tar/TarArchive.cs (+6 -6)
📝 src/SharpCompress/Archives/Zip/ZipArchive.cs (+5 -5)
📝 src/SharpCompress/Compressors/Rar/UnpackV2017/Unpack.unpack50_cpp.cs (+15 -3)
📝 src/SharpCompress/Factories/Factory.cs (+1 -1)
📝 src/SharpCompress/LazyReadOnlyCollection.cs (+1 -1)
📝 src/SharpCompress/NotNullExtensions.cs (+13 -4)
📝 src/SharpCompress/Readers/Arc/ArcReader.cs (+1 -1)
📝 src/SharpCompress/Readers/GZip/GZipReader.cs (+1 -1)
📝 src/SharpCompress/Readers/Rar/RarReader.cs (+3 -3)
📝 src/SharpCompress/Readers/ReaderFactory.cs (+2 -2)
📝 src/SharpCompress/Readers/Tar/TarReader.cs (+1 -1)
📝 src/SharpCompress/Readers/Zip/ZipReader.cs (+2 -2)
📝 src/SharpCompress/Utility.cs (+51 -147)
📝 src/SharpCompress/Writers/GZip/GZipWriter.cs (+1 -1)

...and 8 more files

📄 Description

Trust the framework

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/967 **Author:** [@adamhathcock](https://github.com/adamhathcock) **Created:** 10/22/2025 **Status:** ✅ Merged **Merged:** 10/22/2025 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `adam/reduce-custom-utilities` --- ### 📝 Commits (10+) - [`e0d6cd9`](https://github.com/adamhathcock/sharpcompress/commit/e0d6cd9cb723d126968c0f9f1401fa6de3b0879c) Try to reduce custom functions for array/byte management - [`c823aca`](https://github.com/adamhathcock/sharpcompress/commit/c823acaa3f10527f70630762df69a5ec980b9ee2) optimize ReadFully and Skip - [`084fe72`](https://github.com/adamhathcock/sharpcompress/commit/084fe72b029fddbe034f194fb71325cd240da088) Consolidate not null - [`d8797b6`](https://github.com/adamhathcock/sharpcompress/commit/d8797b69e47dd2e294a74ea09ad57aa729cad1fd) remove do while - [`62bee15`](https://github.com/adamhathcock/sharpcompress/commit/62bee15f00a99efac044f3226e2421e24d6f8a9a) fmt - [`249b8a9`](https://github.com/adamhathcock/sharpcompress/commit/249b8a9cdd54e6f437059d971609f4a611f63958) add AI generated tests - [`513cd4f`](https://github.com/adamhathcock/sharpcompress/commit/513cd4f905ca854e2837d522dfdfd8d562689dc9) some AI suggestions - [`83917d4`](https://github.com/adamhathcock/sharpcompress/commit/83917d4f79f92f472869f4c3b88c902f8261648a) Merge remote-tracking branch 'origin/master' into adam/reduce-custom-utilities - [`a1dfa3d`](https://github.com/adamhathcock/sharpcompress/commit/a1dfa3dfa3ec5ec27fb7aba643f194da4b571586) xplat tests for path characters - [`00df8e9`](https://github.com/adamhathcock/sharpcompress/commit/00df8e930eabee4c6e0de0803678b17d97ee15c1) add windows only compile constant ### 📊 Changes **28 files changed** (+894 additions, -246 deletions) <details> <summary>View changed files</summary> 📝 `Directory.Packages.props` (+0 -1) 📝 `src/SharpCompress/Archives/ArchiveFactory.cs` (+11 -11) 📝 `src/SharpCompress/Archives/GZip/GZipArchive.cs` (+5 -5) 📝 `src/SharpCompress/Archives/IArchiveEntryExtensions.cs` (+1 -1) 📝 `src/SharpCompress/Archives/Rar/RarArchive.cs` (+5 -5) 📝 `src/SharpCompress/Archives/SevenZip/SevenZipArchive.cs` (+5 -5) 📝 `src/SharpCompress/Archives/Tar/TarArchive.cs` (+6 -6) 📝 `src/SharpCompress/Archives/Zip/ZipArchive.cs` (+5 -5) 📝 `src/SharpCompress/Compressors/Rar/UnpackV2017/Unpack.unpack50_cpp.cs` (+15 -3) 📝 `src/SharpCompress/Factories/Factory.cs` (+1 -1) 📝 `src/SharpCompress/LazyReadOnlyCollection.cs` (+1 -1) 📝 `src/SharpCompress/NotNullExtensions.cs` (+13 -4) 📝 `src/SharpCompress/Readers/Arc/ArcReader.cs` (+1 -1) 📝 `src/SharpCompress/Readers/GZip/GZipReader.cs` (+1 -1) 📝 `src/SharpCompress/Readers/Rar/RarReader.cs` (+3 -3) 📝 `src/SharpCompress/Readers/ReaderFactory.cs` (+2 -2) 📝 `src/SharpCompress/Readers/Tar/TarReader.cs` (+1 -1) 📝 `src/SharpCompress/Readers/Zip/ZipReader.cs` (+2 -2) 📝 `src/SharpCompress/Utility.cs` (+51 -147) 📝 `src/SharpCompress/Writers/GZip/GZipWriter.cs` (+1 -1) _...and 8 more files_ </details> ### 📄 Description Trust the framework --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 22:20:19 +00:00

claunia closed this issue 2026-01-29 22:20:19 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

release

adam/merge-release-to-master

dependabot/nuget/xunit.v3-3.2.2

adam/more-explode-async

copilot/fix-infinite-loop-rar-archive

adam/data-descriptor-fix

adam/fix-tests-with-proper-rewind

copilot/fix-data-descriptor-stream-bug

adam/lmza-investigation

adam/create-rar-async

adam/async-rar2

copilot/support-multi-threading-path

copilot/sub-pr-1132-again

adam/memory-perf

copilot/add-performance-benchmarking

copilot/sub-pr-1121

copilot/add-password-support-zip-files

copilot/add-so-optimized-zip-support

adam/rar-async-only

copilot/add-buffered-stream-async-read

copilot/sub-pr-1076

copilot/fix-decompression-exception

copilot/fix-archivefactory-issue

copilot/rationalize-sourcestream-volumes

adam/open-async

copilot/add-ace-archive-support

copilot/sub-pr-1040-again

adam/more-async-3

copilot/fix-tararchive-incomplete-iteration

adam/multi-threaded

copilot/sub-pr-1040

adam/awesome-copilot

copilot/fix-ziparchive-extraction-issue

copilot/fix-tararchive-open-crash

copilot/fix-tar-xz-file-reading-issue

copilot/setup-copilot-instructions

copilot/fix-decompression-performance-issue

copilot/convert-stream-access-to-async

adam/enable-agent

adam/async-deflate

adam/async-rar

adam/more-cleanup

adam/zstd

async-2

zstandard

net461-tests

dmg

async

build-netcore3

recycle-memory-stream

presentation

pax

netcore2

zip_encryption

dotnet-tool

tar_redux

native_zlib

Issue-197

system_buffers

TarNames

7zip_sfx

portable_crypto

WinRT

new_7zip

0.44.5

0.44.4

0.44.3

0.44.2

0.44.1

0.44.0

0.43.0

0.42.1

0.42.0

0.41.0

0.40.0

0.39.0

0.38.0

0.37.2

0.37.1

0.37.0

0.36.0

0.35.0

0.34.2

0.34.1

0.34.0

0.33.0

0.32.2

0.32.1

0.32

0.31

0.30.1

0.30

0.29

0.29.0

0.28.3

0.28.2

0.28.1

0.28

0.27.1

0.27

0.26

0.25.1

0.25

0.24

0.23

0.22

0.21.1

0.21

0.21.0

0.20.0

0.19.2

0.19.1

0.19

0.18.2

0.18.1

0.18

0.17.1

0.17.0

0.16.2

0.16.1

0.16.0

0.15.2

0.15.1

0.15.0

0.14.1

0.14.0

0.13.1

0.13.0

0.12.4

0.12.3

0.12.2

0.12.1

0.12.0

0.11.6

0.11.5

0.11.4

0.11.3

0.11.2

0.11.1

0.11

0.10.3

0.10.2

0.10.1.3

0.10.1.2

0.10.1.1

0.10.1

0.10

0.9

Labels

Clear labels

bug

duplicate

enhancement

feedback requested

not bug

pull-request

Mirrored from GitHub Pull Request

question

up for grabs

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/sharpcompress#1386