starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-12 05:25:03 +00:00
Code Issues 975 Packages Projects Releases 22 Wiki Activity

[PR #993] [MERGED] make test linux only #1413

New Issue
Closed
opened 2026-01-29 22:20:26 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:20:26 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/993
Author: @adamhathcock
Created: 10/28/2025
Status: ✅ Merged
Merged: 10/28/2025
Merged by: @adamhathcock

Base: master ← Head: adam/macos-fixes

📝 Commits (1)

📊 Changes

2 files changed (+22 additions, -28 deletions)

View changed files

📝 tests/SharpCompress.Test/SharpCompress.Test.csproj (+3 -0)
📝 tests/SharpCompress.Test/Tar/TarReaderTests.cs (+19 -28)

📄 Description

This pull request improves platform-specific test handling for symbolic links in tar archives, specifically targeting Linux environments. The main changes involve updating conditional compilation symbols and simplifying logic related to symlink extraction in the test suite.

Platform-specific test improvements:

  • Added a LINUX compilation constant in the SharpCompress.Test.csproj file to enable Linux-specific code paths in tests.
  • Changed the conditional compilation in TarReaderTests.cs to use #if LINUX instead of runtime OS checks, ensuring that the symlink extraction test only runs on Linux.

Code simplification for symlink extraction:

  • Removed unnecessary runtime checks (isWindows) and simplified the symbolic link handling logic in the Tar_GZip_With_Symlink_Entries test, making the code cleaner and more maintainable. [1] [2]

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/993 **Author:** [@adamhathcock](https://github.com/adamhathcock) **Created:** 10/28/2025 **Status:** ✅ Merged **Merged:** 10/28/2025 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `adam/macos-fixes` --- ### 📝 Commits (1) - [`bca0f67`](https://github.com/adamhathcock/sharpcompress/commit/bca0f673448d11c5c0718764ca4dd7576ee5a020) make test linux only ### 📊 Changes **2 files changed** (+22 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `tests/SharpCompress.Test/SharpCompress.Test.csproj` (+3 -0) 📝 `tests/SharpCompress.Test/Tar/TarReaderTests.cs` (+19 -28) </details> ### 📄 Description This pull request improves platform-specific test handling for symbolic links in tar archives, specifically targeting Linux environments. The main changes involve updating conditional compilation symbols and simplifying logic related to symlink extraction in the test suite. **Platform-specific test improvements:** * Added a `LINUX` compilation constant in the `SharpCompress.Test.csproj` file to enable Linux-specific code paths in tests. * Changed the conditional compilation in `TarReaderTests.cs` to use `#if LINUX` instead of runtime OS checks, ensuring that the symlink extraction test only runs on Linux. **Code simplification for symlink extraction:** * Removed unnecessary runtime checks (`isWindows`) and simplified the symbolic link handling logic in the `Tar_GZip_With_Symlink_Entries` test, making the code cleaner and more maintainable. [[1]](diffhunk://#diff-b91ec5d1214f21b7df2b592de93938802bf504caa94e649401a9d4a75e356bfaL228-L242) [[2]](diffhunk://#diff-b91ec5d1214f21b7df2b592de93938802bf504caa94e649401a9d4a75e356bfaL264) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:20:26 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1413
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?