starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-11 13:35:00 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

GZipArchive doesn't support entry re-reading #146

New Issue
Closed
opened 2026-01-29 22:07:21 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:07:21 +00:00
Owner
Copy Link

Originally created by @alexmgerasimov on GitHub (Nov 18, 2016).

Hello!

GZipArchive class doesn't support re-reading of the entry. The code below crashes:

			var inputStream = new MemoryStream();
			using (var fileStream = File.Open("archive.tgz", FileMode.Open))
			{
				fileStream.CopyTo(inputStream);
				inputStream.Position = 0;
			}
			var archive = ArchiveFactory.Open(inputStream);
			var archiveEntry = archive.Entries.First();
			MemoryStream tarStream;
			using (var entryStream = archiveEntry.OpenEntryStream())
			{
				var result = SharpCompress.Archives.Tar.TarArchive.IsTarFile(entryStream);
			}			
			using (var entryStream = archiveEntry.OpenEntryStream())
			{
				tarStream = new MemoryStream();
				entryStream.CopyTo(tarStream);
			}

The exception is the follwoing:

SharpCompress.Compressors.Deflate.ZlibException was unhandled
HResult=-2146233088
Message=Bad state (invalid distance code)
Source=SharpCompress
StackTrace:
в SharpCompress.Compressors.Deflate.InflateManager.Inflate(FlushType flush)
в SharpCompress.Compressors.Deflate.ZlibBaseStream.Read(Byte[] buffer, Int32 offset, Int32 count)
в System.IO.Stream.InternalCopyTo(Stream destination, Int32 bufferSize)
в SevenZipTest.Program.Main(String[] args)
в System.AppDomain._nExecuteAssembly(RuntimeAssembly assembly, String[] args)
в System.AppDomain.ExecuteAssembly(String assemblyFile, Evidence assemblySecurity, String[] args)
в Microsoft.VisualStudio.HostingProcess.HostProc.RunUsersAssembly()
в System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
в System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
в System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
в System.Threading.ThreadHelper.ThreadStart()

It seems to me this happens because GZipFilePart doesn't rewind internal stream in the GetCompressedStream() after first reading. GZipFilePart constructor should remember stream position after GZip header reading and validation and set this initial position to the stream on each GetCompressedStream() call.

Originally created by @alexmgerasimov on GitHub (Nov 18, 2016). Hello! GZipArchive class doesn't support re-reading of the entry. The code below crashes: ``` var inputStream = new MemoryStream(); using (var fileStream = File.Open("archive.tgz", FileMode.Open)) { fileStream.CopyTo(inputStream); inputStream.Position = 0; } var archive = ArchiveFactory.Open(inputStream); var archiveEntry = archive.Entries.First(); MemoryStream tarStream; using (var entryStream = archiveEntry.OpenEntryStream()) { var result = SharpCompress.Archives.Tar.TarArchive.IsTarFile(entryStream); } using (var entryStream = archiveEntry.OpenEntryStream()) { tarStream = new MemoryStream(); entryStream.CopyTo(tarStream); } ``` The exception is the follwoing: > SharpCompress.Compressors.Deflate.ZlibException was unhandled > HResult=-2146233088 > Message=Bad state (invalid distance code) > Source=SharpCompress > StackTrace: > в SharpCompress.Compressors.Deflate.InflateManager.Inflate(FlushType flush) > в SharpCompress.Compressors.Deflate.ZlibBaseStream.Read(Byte[] buffer, Int32 offset, Int32 count) > в System.IO.Stream.InternalCopyTo(Stream destination, Int32 bufferSize) > в SevenZipTest.Program.Main(String[] args) > в System.AppDomain._nExecuteAssembly(RuntimeAssembly assembly, String[] args) > в System.AppDomain.ExecuteAssembly(String assemblyFile, Evidence assemblySecurity, String[] args) > в Microsoft.VisualStudio.HostingProcess.HostProc.RunUsersAssembly() > в System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx) > в System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx) > в System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state) > в System.Threading.ThreadHelper.ThreadStart() > It seems to me this happens because GZipFilePart doesn't rewind internal stream in the GetCompressedStream() after first reading. GZipFilePart constructor should remember stream position after GZip header reading and validation and set this initial position to the stream on each GetCompressedStream() call.
claunia added the bug label 2026-01-29 22:07:21 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#146
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?