starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #1045] Fix Windows-only RAR multi-threading test failure #1472

New Issue
Open
opened 2026-01-29 22:20:44 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:20:44 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/adamhathcock/sharpcompress/pull/1045

State: closed
Merged: No

  • Create IRarUnpackFactory interface with factory implementations
  • Update RarStream to use factory pattern for creating owned IRarUnpack instances
  • Support both factory (non-solid) and shared instance (solid) modes
  • Update RarCrcStream and RarBLAKE2spStream for both modes
  • Update RarArchiveEntry to use factory for non-solid, shared for solid
  • Update RarReader to use factory for non-solid, shared for solid
  • Verify all 871 tests pass
  • Code review
  • Security scan (CodeQL)

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

**Original Pull Request:** https://github.com/adamhathcock/sharpcompress/pull/1045 **State:** closed **Merged:** No --- - [x] Create IRarUnpackFactory interface with factory implementations - [x] Update RarStream to use factory pattern for creating owned IRarUnpack instances - [x] Support both factory (non-solid) and shared instance (solid) modes - [x] Update RarCrcStream and RarBLAKE2spStream for both modes - [x] Update RarArchiveEntry to use factory for non-solid, shared for solid - [x] Update RarReader to use factory for non-solid, shared for solid - [x] Verify all 871 tests pass - [x] Code review - [x] Security scan (CodeQL) <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey).
claunia added the pull-request label 2026-01-29 22:20:44 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1472
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?