starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #1093] [MERGED] Add back System.Buffers and System.Memory to central package management #1519

New Issue
Closed
opened 2026-01-29 22:20:57 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:20:57 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/1093
Author: @Copilot
Created: 12/30/2025
Status: ✅ Merged
Merged: 12/30/2025
Merged by: @adamhathcock

Base: adam/update-deps2 ← Head: copilot/sub-pr-1091

📝 Commits (2)

  • 5e3f01d Initial plan
  • 128c9e6 Add back System.Buffers and System.Memory packages

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 Directory.Packages.props (+2 -0)

📄 Description

The dependency update removed System.Buffers and System.Memory from Directory.Packages.props, but these packages are still referenced by SharpCompress.csproj for .NET Framework 4.8 targets, causing build failures.

Changes

  • Added System.Buffers 4.6.1 to Directory.Packages.props
  • Added System.Memory 4.6.3 to Directory.Packages.props

Versions were set to satisfy transitive dependency constraints from System.Text.Encoding.CodePages 10.0.0, which requires System.Memory >= 4.6.3 and System.Buffers >= 4.6.1.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/1093 **Author:** [@Copilot](https://github.com/apps/copilot-swe-agent) **Created:** 12/30/2025 **Status:** ✅ Merged **Merged:** 12/30/2025 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `adam/update-deps2` ← **Head:** `copilot/sub-pr-1091` --- ### 📝 Commits (2) - [`5e3f01d`](https://github.com/adamhathcock/sharpcompress/commit/5e3f01dc0322fc2d6785d15727d051a42f7efbfa) Initial plan - [`128c9e6`](https://github.com/adamhathcock/sharpcompress/commit/128c9e639f5d7a34d47e0f5272e855798edc961b) Add back System.Buffers and System.Memory packages ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `Directory.Packages.props` (+2 -0) </details> ### 📄 Description The dependency update removed `System.Buffers` and `System.Memory` from `Directory.Packages.props`, but these packages are still referenced by `SharpCompress.csproj` for .NET Framework 4.8 targets, causing build failures. ## Changes - Added `System.Buffers` 4.6.1 to `Directory.Packages.props` - Added `System.Memory` 4.6.3 to `Directory.Packages.props` Versions were set to satisfy transitive dependency constraints from `System.Text.Encoding.CodePages` 10.0.0, which requires `System.Memory >= 4.6.3` and `System.Buffers >= 4.6.1`. <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:20:57 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1519
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?