[PR #1096] [CLOSED] RAR async #1523

New Issue

Open

opened 2026-01-29 22:20:57 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 22:20:57 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/1096
Author: @adamhathcock
Created: 1/3/2026
Status: ❌ Closed

Base: master ← Head: adam/rar-async-only

---

📝 Commits (7)

• 955e1d8 add async testing
• 0ed66ae add rar async only with failures
• 676fb0b Initial plan
• 98e509d Add async support for RAR header reading (work in progress)
• f967dd0 Implement full async RAR header reading pipeline and fix SharpCompressStream
• 6ef1dd5 Merge pull request #1097 from adamhathcock/copilot/sub-pr-1096
• 39d986a async loading for rar is better

📊 Changes

27 files changed (+1230 additions, -56 deletions)

View changed files

📝 src/SharpCompress/Archives/Rar/RarArchive.cs (+19 -0)
📝 src/SharpCompress/Archives/SevenZip/SevenZipArchive.cs (+25 -0)
📝 src/SharpCompress/Common/Rar/Headers/MarkHeader.cs (+128 -0)
📝 src/SharpCompress/Common/Rar/Headers/RarHeader.cs (+101 -8)
📝 src/SharpCompress/Common/Rar/Headers/RarHeaderFactory.cs (+193 -0)
📝 src/SharpCompress/Common/Rar/RarCrcBinaryReader.cs (+25 -0)
📝 src/SharpCompress/Common/Rar/RarCryptoBinaryReader.cs (+47 -0)
📝 src/SharpCompress/Common/Rar/RarVolume.cs (+60 -0)
📝 src/SharpCompress/Common/Zip/StreamingZipHeaderFactory.cs (+193 -0)
📝 src/SharpCompress/Factories/RarFactory.cs (+8 -0)
📝 src/SharpCompress/IO/MarkingBinaryReader.cs (+166 -0)
📝 src/SharpCompress/IO/SharpCompressStream.cs (+1 -2)
📝 src/SharpCompress/Readers/AbstractReader.cs (+37 -2)
📝 src/SharpCompress/Readers/Arc/ArcReader.cs (+16 -0)
📝 src/SharpCompress/Readers/Arj/ArjReader.cs (+42 -0)
📝 src/SharpCompress/Readers/Arj/MultiVolumeArjReader.cs (+1 -0)
📝 src/SharpCompress/Readers/Arj/SingleVolumeArjReader.cs (+18 -18)
📝 src/SharpCompress/Readers/GZip/GZipReader.cs (+14 -0)
📝 src/SharpCompress/Readers/Rar/RarReader.cs (+16 -0)
📝 src/SharpCompress/Readers/Rar/RarReaderVolume.cs (+5 -0)

...and 7 more files

📄 Description

This should make tests for asynchronous overloads use the AsyncOnlyStream for RAR and force all RAR paths to use asynchronous methods to read from streams

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/1096 **Author:** [@adamhathcock](https://github.com/adamhathcock) **Created:** 1/3/2026 **Status:** ❌ Closed **Base:** `master` ← **Head:** `adam/rar-async-only` --- ### 📝 Commits (7) - [`955e1d8`](https://github.com/adamhathcock/sharpcompress/commit/955e1d8742d272280af44b2bc5066a7d2d12337e) add async testing - [`0ed66ae`](https://github.com/adamhathcock/sharpcompress/commit/0ed66ae6d06357746456397f04463a2570850c76) add rar async only with failures - [`676fb0b`](https://github.com/adamhathcock/sharpcompress/commit/676fb0ba520c18eb474ad4a92fbeaf882ec9052c) Initial plan - [`98e509d`](https://github.com/adamhathcock/sharpcompress/commit/98e509df46a1b0249dff92626fcb9616e48ece4c) Add async support for RAR header reading (work in progress) - [`f967dd0`](https://github.com/adamhathcock/sharpcompress/commit/f967dd0d3df77c00bdee225bc8cd00e98fa094a5) Implement full async RAR header reading pipeline and fix SharpCompressStream - [`6ef1dd5`](https://github.com/adamhathcock/sharpcompress/commit/6ef1dd590f5c47fdc204a166594e8f59ae13f8c9) Merge pull request #1097 from adamhathcock/copilot/sub-pr-1096 - [`39d986a`](https://github.com/adamhathcock/sharpcompress/commit/39d986a62ce434a6db80b85157f0aabde0bf29d0) async loading for rar is better ### 📊 Changes **27 files changed** (+1230 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Archives/Rar/RarArchive.cs` (+19 -0) 📝 `src/SharpCompress/Archives/SevenZip/SevenZipArchive.cs` (+25 -0) 📝 `src/SharpCompress/Common/Rar/Headers/MarkHeader.cs` (+128 -0) 📝 `src/SharpCompress/Common/Rar/Headers/RarHeader.cs` (+101 -8) 📝 `src/SharpCompress/Common/Rar/Headers/RarHeaderFactory.cs` (+193 -0) 📝 `src/SharpCompress/Common/Rar/RarCrcBinaryReader.cs` (+25 -0) 📝 `src/SharpCompress/Common/Rar/RarCryptoBinaryReader.cs` (+47 -0) 📝 `src/SharpCompress/Common/Rar/RarVolume.cs` (+60 -0) 📝 `src/SharpCompress/Common/Zip/StreamingZipHeaderFactory.cs` (+193 -0) 📝 `src/SharpCompress/Factories/RarFactory.cs` (+8 -0) 📝 `src/SharpCompress/IO/MarkingBinaryReader.cs` (+166 -0) 📝 `src/SharpCompress/IO/SharpCompressStream.cs` (+1 -2) 📝 `src/SharpCompress/Readers/AbstractReader.cs` (+37 -2) 📝 `src/SharpCompress/Readers/Arc/ArcReader.cs` (+16 -0) 📝 `src/SharpCompress/Readers/Arj/ArjReader.cs` (+42 -0) 📝 `src/SharpCompress/Readers/Arj/MultiVolumeArjReader.cs` (+1 -0) 📝 `src/SharpCompress/Readers/Arj/SingleVolumeArjReader.cs` (+18 -18) 📝 `src/SharpCompress/Readers/GZip/GZipReader.cs` (+14 -0) 📝 `src/SharpCompress/Readers/Rar/RarReader.cs` (+16 -0) 📝 `src/SharpCompress/Readers/Rar/RarReaderVolume.cs` (+5 -0) _...and 7 more files_ </details> ### 📄 Description This should make tests for asynchronous overloads use the `AsyncOnlyStream` for RAR and force all RAR paths to use asynchronous methods to read from streams --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 22:20:57 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

release

adam/merge-release-to-master

dependabot/nuget/xunit.v3-3.2.2

adam/more-explode-async

copilot/fix-infinite-loop-rar-archive

adam/data-descriptor-fix

adam/fix-tests-with-proper-rewind

copilot/fix-data-descriptor-stream-bug

adam/lmza-investigation

adam/create-rar-async

adam/async-rar2

copilot/support-multi-threading-path

copilot/sub-pr-1132-again

adam/memory-perf

copilot/add-performance-benchmarking

copilot/sub-pr-1121

copilot/add-password-support-zip-files

copilot/add-so-optimized-zip-support

adam/rar-async-only

copilot/add-buffered-stream-async-read

copilot/sub-pr-1076

copilot/fix-decompression-exception

copilot/fix-archivefactory-issue

copilot/rationalize-sourcestream-volumes

adam/open-async

copilot/add-ace-archive-support

copilot/sub-pr-1040-again

adam/more-async-3

copilot/fix-tararchive-incomplete-iteration

adam/multi-threaded

copilot/sub-pr-1040

adam/awesome-copilot

copilot/fix-ziparchive-extraction-issue

copilot/fix-tararchive-open-crash

copilot/fix-tar-xz-file-reading-issue

copilot/setup-copilot-instructions

copilot/fix-decompression-performance-issue

copilot/convert-stream-access-to-async

adam/enable-agent

adam/async-deflate

adam/async-rar

adam/more-cleanup

adam/zstd

async-2

zstandard

net461-tests

dmg

async

build-netcore3

recycle-memory-stream

presentation

pax

netcore2

zip_encryption

dotnet-tool

tar_redux

native_zlib

Issue-197

system_buffers

TarNames

7zip_sfx

portable_crypto

WinRT

new_7zip

0.44.5

0.44.4

0.44.3

0.44.2

0.44.1

0.44.0

0.43.0

0.42.1

0.42.0

0.41.0

0.40.0

0.39.0

0.38.0

0.37.2

0.37.1

0.37.0

0.36.0

0.35.0

0.34.2

0.34.1

0.34.0

0.33.0

0.32.2

0.32.1

0.32

0.31

0.30.1

0.30

0.29

0.29.0

0.28.3

0.28.2

0.28.1

0.28

0.27.1

0.27

0.26

0.25.1

0.25

0.24

0.23

0.22

0.21.1

0.21

0.21.0

0.20.0

0.19.2

0.19.1

0.19

0.18.2

0.18.1

0.18

0.17.1

0.17.0

0.16.2

0.16.1

0.16.0

0.15.2

0.15.1

0.15.0

0.14.1

0.14.0

0.13.1

0.13.0

0.12.4

0.12.3

0.12.2

0.12.1

0.12.0

0.11.6

0.11.5

0.11.4

0.11.3

0.11.2

0.11.1

0.11

0.10.3

0.10.2

0.10.1.3

0.10.1.2

0.10.1.1

0.10.1

0.10

0.9

Labels

Clear labels

bug

duplicate

enhancement

feedback requested

not bug

pull-request

Mirrored from GitHub Pull Request

question

up for grabs

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/sharpcompress#1523