[PR #1117] [MERGED] Change ArchiveEncoding to interface. #1547

New Issue

Open

opened 2026-01-29 22:21:05 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 22:21:05 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/1117
Author: @adamhathcock
Created: 1/7/2026
Status: ✅ Merged
Merged: 1/8/2026
Merged by: @adamhathcock

Base: master ← Head: adam/rework-archive-encoding

---

📝 Commits (6)

• 725503d Change ArchiveEncoding to interface. Simplify class. Question what to do about Forced and complex access
• bd3cda0 Some restoring of functionality
• 486fdf1 move to own files and refactor UTF8 usage
• 68451bd Use explicit enum, add comments
• 3215204 fmt
• 66e9de2 fixed comment

📊 Changes

24 files changed (+163 additions, -84 deletions)

View changed files

📝 src/SharpCompress/Common/Ace/Headers/AceFileHeader.cs (+1 -1)
📝 src/SharpCompress/Common/Ace/Headers/AceHeader.cs (+2 -2)
📝 src/SharpCompress/Common/Ace/Headers/AceMainHeader.cs (+1 -1)
📝 src/SharpCompress/Common/Arc/ArcEntryHeader.cs (+2 -2)
📝 src/SharpCompress/Common/ArchiveEncoding.cs (+5 -49)
➕ src/SharpCompress/Common/ArchiveEncodingExtensions.cs (+87 -0)
📝 src/SharpCompress/Common/FilePart.cs (+2 -2)
📝 src/SharpCompress/Common/GZip/GZipFilePart.cs (+1 -1)
➕ src/SharpCompress/Common/IArchiveEncoding.cs (+36 -0)
📝 src/SharpCompress/Common/OptionsBase.cs (+1 -1)
📝 src/SharpCompress/Common/Rar/Headers/RarHeader.cs (+3 -3)
📝 src/SharpCompress/Common/SevenZip/SevenZipFilePart.cs (+1 -1)
📝 src/SharpCompress/Common/Tar/Headers/TarHeader.cs (+2 -2)
📝 src/SharpCompress/Common/Tar/TarEntry.cs (+1 -1)
📝 src/SharpCompress/Common/Tar/TarHeaderFactory.cs (+1 -1)
📝 src/SharpCompress/Common/Zip/Headers/DirectoryEntryHeader.cs (+3 -3)
📝 src/SharpCompress/Common/Zip/Headers/LocalEntryHeader.cs (+2 -2)
📝 src/SharpCompress/Common/Zip/Headers/ZipFileEntry.cs (+2 -2)
📝 src/SharpCompress/Common/Zip/PkwareTraditionalEncryptionData.cs (+3 -3)
📝 src/SharpCompress/Common/Zip/SeekableZipHeaderFactory.cs (+1 -1)

...and 4 more files

📄 Description

Simplify class. Question what to do about Forced and complex access. Was custom encoder used?

Should I have the interface use a Func then default to what I use but allow for anything?

Started by https://github.com/adamhathcock/sharpcompress/issues/1115

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/1117 **Author:** [@adamhathcock](https://github.com/adamhathcock) **Created:** 1/7/2026 **Status:** ✅ Merged **Merged:** 1/8/2026 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `adam/rework-archive-encoding` --- ### 📝 Commits (6) - [`725503d`](https://github.com/adamhathcock/sharpcompress/commit/725503d1ceb316b61385b940bc8ee74b7d013472) Change ArchiveEncoding to interface. Simplify class. Question what to do about Forced and complex access - [`bd3cda0`](https://github.com/adamhathcock/sharpcompress/commit/bd3cda0617bd8c819d1d5308f86d13a4f2a9feb8) Some restoring of functionality - [`486fdf1`](https://github.com/adamhathcock/sharpcompress/commit/486fdf118be9952f56170962c4dbb65e222f4528) move to own files and refactor UTF8 usage - [`68451bd`](https://github.com/adamhathcock/sharpcompress/commit/68451bd75ff23fd7dfc81a6af3b0d4b3952c20ce) Use explicit enum, add comments - [`3215204`](https://github.com/adamhathcock/sharpcompress/commit/321520408ba4caca70b2ac358b7a6b92e241147d) fmt - [`66e9de2`](https://github.com/adamhathcock/sharpcompress/commit/66e9de2685b6e4e3eca2207913134639345bf824) fixed comment ### 📊 Changes **24 files changed** (+163 additions, -84 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Common/Ace/Headers/AceFileHeader.cs` (+1 -1) 📝 `src/SharpCompress/Common/Ace/Headers/AceHeader.cs` (+2 -2) 📝 `src/SharpCompress/Common/Ace/Headers/AceMainHeader.cs` (+1 -1) 📝 `src/SharpCompress/Common/Arc/ArcEntryHeader.cs` (+2 -2) 📝 `src/SharpCompress/Common/ArchiveEncoding.cs` (+5 -49) ➕ `src/SharpCompress/Common/ArchiveEncodingExtensions.cs` (+87 -0) 📝 `src/SharpCompress/Common/FilePart.cs` (+2 -2) 📝 `src/SharpCompress/Common/GZip/GZipFilePart.cs` (+1 -1) ➕ `src/SharpCompress/Common/IArchiveEncoding.cs` (+36 -0) 📝 `src/SharpCompress/Common/OptionsBase.cs` (+1 -1) 📝 `src/SharpCompress/Common/Rar/Headers/RarHeader.cs` (+3 -3) 📝 `src/SharpCompress/Common/SevenZip/SevenZipFilePart.cs` (+1 -1) 📝 `src/SharpCompress/Common/Tar/Headers/TarHeader.cs` (+2 -2) 📝 `src/SharpCompress/Common/Tar/TarEntry.cs` (+1 -1) 📝 `src/SharpCompress/Common/Tar/TarHeaderFactory.cs` (+1 -1) 📝 `src/SharpCompress/Common/Zip/Headers/DirectoryEntryHeader.cs` (+3 -3) 📝 `src/SharpCompress/Common/Zip/Headers/LocalEntryHeader.cs` (+2 -2) 📝 `src/SharpCompress/Common/Zip/Headers/ZipFileEntry.cs` (+2 -2) 📝 `src/SharpCompress/Common/Zip/PkwareTraditionalEncryptionData.cs` (+3 -3) 📝 `src/SharpCompress/Common/Zip/SeekableZipHeaderFactory.cs` (+1 -1) _...and 4 more files_ </details> ### 📄 Description Simplify class. Question what to do about Forced and complex access. Was custom encoder used? Should I have the interface use a `Func` then default to what I use but allow for anything? Started by https://github.com/adamhathcock/sharpcompress/issues/1115 --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 22:21:05 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

release

adam/merge-release-to-master

dependabot/nuget/xunit.v3-3.2.2

adam/more-explode-async

copilot/fix-infinite-loop-rar-archive

adam/data-descriptor-fix

adam/fix-tests-with-proper-rewind

copilot/fix-data-descriptor-stream-bug

adam/lmza-investigation

adam/create-rar-async

adam/async-rar2

copilot/support-multi-threading-path

copilot/sub-pr-1132-again

adam/memory-perf

copilot/add-performance-benchmarking

copilot/sub-pr-1121

copilot/add-password-support-zip-files

copilot/add-so-optimized-zip-support

adam/rar-async-only

copilot/add-buffered-stream-async-read

copilot/sub-pr-1076

copilot/fix-decompression-exception

copilot/fix-archivefactory-issue

copilot/rationalize-sourcestream-volumes

adam/open-async

copilot/add-ace-archive-support

copilot/sub-pr-1040-again

adam/more-async-3

copilot/fix-tararchive-incomplete-iteration

adam/multi-threaded

copilot/sub-pr-1040

adam/awesome-copilot

copilot/fix-ziparchive-extraction-issue

copilot/fix-tararchive-open-crash

copilot/fix-tar-xz-file-reading-issue

copilot/setup-copilot-instructions

copilot/fix-decompression-performance-issue

copilot/convert-stream-access-to-async

adam/enable-agent

adam/async-deflate

adam/async-rar

adam/more-cleanup

adam/zstd

async-2

zstandard

net461-tests

dmg

async

build-netcore3

recycle-memory-stream

presentation

pax

netcore2

zip_encryption

dotnet-tool

tar_redux

native_zlib

Issue-197

system_buffers

TarNames

7zip_sfx

portable_crypto

WinRT

new_7zip

0.44.5

0.44.4

0.44.3

0.44.2

0.44.1

0.44.0

0.43.0

0.42.1

0.42.0

0.41.0

0.40.0

0.39.0

0.38.0

0.37.2

0.37.1

0.37.0

0.36.0

0.35.0

0.34.2

0.34.1

0.34.0

0.33.0

0.32.2

0.32.1

0.32

0.31

0.30.1

0.30

0.29

0.29.0

0.28.3

0.28.2

0.28.1

0.28

0.27.1

0.27

0.26

0.25.1

0.25

0.24

0.23

0.22

0.21.1

0.21

0.21.0

0.20.0

0.19.2

0.19.1

0.19

0.18.2

0.18.1

0.18

0.17.1

0.17.0

0.16.2

0.16.1

0.16.0

0.15.2

0.15.1

0.15.0

0.14.1

0.14.0

0.13.1

0.13.0

0.12.4

0.12.3

0.12.2

0.12.1

0.12.0

0.11.6

0.11.5

0.11.4

0.11.3

0.11.2

0.11.1

0.11

0.10.3

0.10.2

0.10.1.3

0.10.1.2

0.10.1.1

0.10.1

0.10

0.9

Labels

Clear labels

bug

duplicate

enhancement

feedback requested

not bug

pull-request

Mirrored from GitHub Pull Request

question

up for grabs

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/sharpcompress#1547