starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #1122] [MERGED] Readd netstandard 2.0 #1550

New Issue
Closed
opened 2026-01-29 22:21:06 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:21:06 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/1122
Author: @adamhathcock
Created: 1/8/2026
Status: ✅ Merged
Merged: 1/8/2026
Merged by: @adamhathcock

Base: master ← Head: adam/netstandard-20-readd

📝 Commits (1)

📊 Changes

3 files changed (+107 additions, -6 deletions)

View changed files

📝 src/SharpCompress/Common/Zip/WinzipAesEncryptionData.cs (+1 -1)
📝 src/SharpCompress/SharpCompress.csproj (+2 -5)
📝 src/SharpCompress/packages.lock.json (+104 -0)

📄 Description

addresses later comments on https://github.com/adamhathcock/sharpcompress/issues/1048

This pull request expands support for the SharpCompress library by adding the netstandard2.0 target framework. The changes ensure compatibility with more .NET platforms, update dependency management, and adjust conditional logic to include the new framework where appropriate.

Framework support and compatibility:

  • Added netstandard2.0 to the TargetFrameworks property in SharpCompress.csproj, enabling builds for .NET Standard 2.0.
  • Updated conditional logic in WinzipAesEncryptionData.cs to include NETSTANDARD2_0 alongside NETFRAMEWORK for password-based key derivation.

Dependency management:

  • Modified package references in SharpCompress.csproj so that Microsoft.Bcl.AsyncInterfaces, System.Text.Encoding.CodePages, and System.Buffers are included for both net48 and netstandard20 targets.
  • Added a new section for .NETStandard,Version=v2.0 in packages.lock.json, specifying direct and transitive dependencies required for this framework.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/1122 **Author:** [@adamhathcock](https://github.com/adamhathcock) **Created:** 1/8/2026 **Status:** ✅ Merged **Merged:** 1/8/2026 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `master` ← **Head:** `adam/netstandard-20-readd` --- ### 📝 Commits (1) - [`ec83cf5`](https://github.com/adamhathcock/sharpcompress/commit/ec83cf588f082d3c3689d39c962b0ea774d048ac) Readd netstandard 2.0 ### 📊 Changes **3 files changed** (+107 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/SharpCompress/Common/Zip/WinzipAesEncryptionData.cs` (+1 -1) 📝 `src/SharpCompress/SharpCompress.csproj` (+2 -5) 📝 `src/SharpCompress/packages.lock.json` (+104 -0) </details> ### 📄 Description addresses later comments on https://github.com/adamhathcock/sharpcompress/issues/1048 This pull request expands support for the SharpCompress library by adding the `netstandard2.0` target framework. The changes ensure compatibility with more .NET platforms, update dependency management, and adjust conditional logic to include the new framework where appropriate. **Framework support and compatibility:** * Added `netstandard2.0` to the `TargetFrameworks` property in `SharpCompress.csproj`, enabling builds for .NET Standard 2.0. * Updated conditional logic in `WinzipAesEncryptionData.cs` to include `NETSTANDARD2_0` alongside `NETFRAMEWORK` for password-based key derivation. **Dependency management:** * Modified package references in `SharpCompress.csproj` so that `Microsoft.Bcl.AsyncInterfaces`, `System.Text.Encoding.CodePages`, and `System.Buffers` are included for both `net48` and `netstandard20` targets. * Added a new section for `.NETStandard,Version=v2.0` in `packages.lock.json`, specifying direct and transitive dependencies required for this framework. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:21:06 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1550
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?