starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-04 05:25:00 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #1124] [MERGED] Fix async test method naming inconsistency in ZipArchiveAsyncTests #1552

New Issue
Open
opened 2026-01-29 22:21:07 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:21:07 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/1124
Author: @Copilot
Created: 1/12/2026
Status: ✅ Merged
Merged: 1/12/2026
Merged by: @adamhathcock

Base: adam/async ← Head: copilot/sub-pr-1121

📝 Commits (2)

  • 0f37049 Initial plan
  • 921cff0 Fix async test method naming: rename Sync to Async

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 tests/SharpCompress.Test/Zip/ZipArchiveAsyncTests.cs (+2 -2)

📄 Description

Two async test methods in ZipArchiveAsyncTests.cs had "Sync" suffixes despite being async methods using await.

Changes

  • Renamed Zip_Random_Write_Remove_Sync → Zip_Random_Write_Remove_Async
  • Renamed Zip_Random_Write_Add_Sync → Zip_Random_Write_Add_Async

Both methods use async ValueTask and await archive.SaveToAsync(), so the "Async" suffix correctly reflects their implementation.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/1124 **Author:** [@Copilot](https://github.com/apps/copilot-swe-agent) **Created:** 1/12/2026 **Status:** ✅ Merged **Merged:** 1/12/2026 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `adam/async` ← **Head:** `copilot/sub-pr-1121` --- ### 📝 Commits (2) - [`0f37049`](https://github.com/adamhathcock/sharpcompress/commit/0f37049aad33c302e42965c84bcc4bdf0cfa457c) Initial plan - [`921cff0`](https://github.com/adamhathcock/sharpcompress/commit/921cff00a5bc3e68e4a676d7c1b521f951b14d42) Fix async test method naming: rename Sync to Async ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `tests/SharpCompress.Test/Zip/ZipArchiveAsyncTests.cs` (+2 -2) </details> ### 📄 Description Two async test methods in `ZipArchiveAsyncTests.cs` had "Sync" suffixes despite being async methods using `await`. ## Changes - Renamed `Zip_Random_Write_Remove_Sync` → `Zip_Random_Write_Remove_Async` - Renamed `Zip_Random_Write_Add_Sync` → `Zip_Random_Write_Add_Async` Both methods use `async ValueTask` and `await archive.SaveToAsync()`, so the "Async" suffix correctly reflects their implementation. <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:21:07 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1552
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?