starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-04 05:25:00 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #1125] [MERGED] [WIP] Update ZipReader and ZipWriter based on review feedback #1553

New Issue
Closed
opened 2026-01-29 22:21:07 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:21:07 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/1125
Author: @Copilot
Created: 1/12/2026
Status: ✅ Merged
Merged: 1/12/2026
Merged by: @adamhathcock

Base: adam/async ← Head: copilot/sub-pr-1121-again

📝 Commits (2)

  • 90c8ff8 Initial plan
  • 95c409d Change File.Create to File.OpenWrite in TarReaderAsyncTests for consistency

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 tests/SharpCompress.Test/Tar/TarReaderAsyncTests.cs (+1 -1)

📄 Description

  • Analyze the feedback about inconsistent usage of File.Create vs File.OpenWrite
  • Identify the issue in TarReaderAsyncTests.cs at line 95
  • Change File.Create back to File.OpenWrite for consistency with sync version and other async tests
  • Verify the change with tests

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/1125 **Author:** [@Copilot](https://github.com/apps/copilot-swe-agent) **Created:** 1/12/2026 **Status:** ✅ Merged **Merged:** 1/12/2026 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `adam/async` ← **Head:** `copilot/sub-pr-1121-again` --- ### 📝 Commits (2) - [`90c8ff8`](https://github.com/adamhathcock/sharpcompress/commit/90c8ff8650697b64b638a05db4b5d6c1eb3a961b) Initial plan - [`95c409d`](https://github.com/adamhathcock/sharpcompress/commit/95c409d97944444952d67f00a764a19b0f57c6a3) Change File.Create to File.OpenWrite in TarReaderAsyncTests for consistency ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `tests/SharpCompress.Test/Tar/TarReaderAsyncTests.cs` (+1 -1) </details> ### 📄 Description - [x] Analyze the feedback about inconsistent usage of File.Create vs File.OpenWrite - [x] Identify the issue in TarReaderAsyncTests.cs at line 95 - [x] Change File.Create back to File.OpenWrite for consistency with sync version and other async tests - [x] Verify the change with tests <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:21:07 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1553
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?