starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #1124] Fix async test method naming inconsistency in ZipArchiveAsyncTests #1555

New Issue
Open
opened 2026-01-29 22:21:07 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:21:07 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/adamhathcock/sharpcompress/pull/1124

State: closed
Merged: Yes

Two async test methods in ZipArchiveAsyncTests.cs had "Sync" suffixes despite being async methods using await.

Changes

  • Renamed Zip_Random_Write_Remove_Sync → Zip_Random_Write_Remove_Async
  • Renamed Zip_Random_Write_Add_Sync → Zip_Random_Write_Add_Async

Both methods use async ValueTask and await archive.SaveToAsync(), so the "Async" suffix correctly reflects their implementation.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

**Original Pull Request:** https://github.com/adamhathcock/sharpcompress/pull/1124 **State:** closed **Merged:** Yes --- Two async test methods in `ZipArchiveAsyncTests.cs` had "Sync" suffixes despite being async methods using `await`. ## Changes - Renamed `Zip_Random_Write_Remove_Sync` → `Zip_Random_Write_Remove_Async` - Renamed `Zip_Random_Write_Add_Sync` → `Zip_Random_Write_Add_Async` Both methods use `async ValueTask` and `await archive.SaveToAsync()`, so the "Async" suffix correctly reflects their implementation. <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs.
claunia added the pull-request label 2026-01-29 22:21:07 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1555
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?