starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #1126] [MERGED] Fix typo in TestBase.cs comment #1556

New Issue
Open
opened 2026-01-29 22:21:07 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:21:07 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/1126
Author: @Copilot
Created: 1/12/2026
Status: ✅ Merged
Merged: 1/12/2026
Merged by: @adamhathcock

Base: adam/async ← Head: copilot/sub-pr-1121-another-one

📝 Commits (2)

  • 292da90 Initial plan
  • 64a09eb Fix typo in TestBase.cs comment: 'akways' -> 'always'

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 tests/SharpCompress.Test/TestBase.cs (+1 -1)

📄 Description

Addresses feedback from PR #1121 - corrects spelling error in comment explaining async disposal pattern.

Changes

  • Fixed typo in tests/SharpCompress.Test/TestBase.cs line 58: "akways" → "always"

The comment now correctly reads:

//always use async dispose since we have I/O and sync Dispose doesn't wait when using xunit

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/1126 **Author:** [@Copilot](https://github.com/apps/copilot-swe-agent) **Created:** 1/12/2026 **Status:** ✅ Merged **Merged:** 1/12/2026 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `adam/async` ← **Head:** `copilot/sub-pr-1121-another-one` --- ### 📝 Commits (2) - [`292da90`](https://github.com/adamhathcock/sharpcompress/commit/292da90184f6e835a955a9320567a48fb36b09ba) Initial plan - [`64a09eb`](https://github.com/adamhathcock/sharpcompress/commit/64a09eb0f8a99fcbd8311f2a4efbec6352ba3c45) Fix typo in TestBase.cs comment: 'akways' -> 'always' ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `tests/SharpCompress.Test/TestBase.cs` (+1 -1) </details> ### 📄 Description Addresses feedback from PR #1121 - corrects spelling error in comment explaining async disposal pattern. ## Changes - Fixed typo in `tests/SharpCompress.Test/TestBase.cs` line 58: "akways" → "always" The comment now correctly reads: ```csharp //always use async dispose since we have I/O and sync Dispose doesn't wait when using xunit ``` <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:21:07 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1556
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?