starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #1126] Fix typo in TestBase.cs comment #1559

New Issue
Open
opened 2026-01-29 22:21:08 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:21:08 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/adamhathcock/sharpcompress/pull/1126

State: closed
Merged: Yes

Addresses feedback from PR #1121 - corrects spelling error in comment explaining async disposal pattern.

Changes

  • Fixed typo in tests/SharpCompress.Test/TestBase.cs line 58: "akways" → "always"

The comment now correctly reads:

//always use async dispose since we have I/O and sync Dispose doesn't wait when using xunit

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

**Original Pull Request:** https://github.com/adamhathcock/sharpcompress/pull/1126 **State:** closed **Merged:** Yes --- Addresses feedback from PR #1121 - corrects spelling error in comment explaining async disposal pattern. ## Changes - Fixed typo in `tests/SharpCompress.Test/TestBase.cs` line 58: "akways" → "always" The comment now correctly reads: ```csharp //always use async dispose since we have I/O and sync Dispose doesn't wait when using xunit ``` <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey).
claunia added the pull-request label 2026-01-29 22:21:08 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1559
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?