starred/sharpcompress
1
0
Fork 0
mirror of https://github.com/adamhathcock/sharpcompress.git synced 2026-02-03 21:23:38 +00:00
Code Issues 975 Packages Projects Releases 20 Wiki Activity

[PR #1136] [MERGED] Upgrade xunit to v3 #1572

New Issue
Open
opened 2026-01-29 22:21:11 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 22:21:11 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/adamhathcock/sharpcompress/pull/1136
Author: @adamhathcock
Created: 1/16/2026
Status: ✅ Merged
Merged: 1/16/2026
Merged by: @adamhathcock

Base: adam/async-creation ← Head: adam/upgrade-xunit

📝 Commits (7)

  • 63e124e Upgrade xunit to v3
  • 75cc368 Initial plan
  • 2906529 Fix ReaderFactory.OpenAsyncReader to use async IsArchiveAsync methods
  • e919930 Fix Archive async tests to not use AsyncOnlyStream (archives need seekable streams)
  • c7da19f Format code with CSharpier
  • 0de5c59 Restore AsyncOnlyStream in archive async tests as requested
  • c958d18 Merge pull request #1137 from adamhathcock/copilot/sub-pr-1136

📊 Changes

17 files changed (+297 additions, -108 deletions)

View changed files

📝 Directory.Packages.props (+1 -1)
📝 src/SharpCompress/Readers/ReaderFactory.cs (+13 -5)
📝 tests/SharpCompress.Test/Ace/AceReaderAsyncTests.cs (+3 -3)
📝 tests/SharpCompress.Test/Arj/ArjReaderAsyncTests.cs (+4 -4)
📝 tests/SharpCompress.Test/GZip/AsyncTests.cs (+4 -4)
📝 tests/SharpCompress.Test/GZip/GZipReaderAsyncTests.cs (+2 -2)
📝 tests/SharpCompress.Test/ProgressReportTests.cs (+1 -1)
📝 tests/SharpCompress.Test/Rar/RarReaderAsyncTests.cs (+5 -5)
📝 tests/SharpCompress.Test/ReaderTests.cs (+1 -1)
📝 tests/SharpCompress.Test/SharpCompress.Test.csproj (+3 -2)
📝 tests/SharpCompress.Test/Tar/TarArchiveAsyncTests.cs (+4 -1)
📝 tests/SharpCompress.Test/Tar/TarReaderAsyncTests.cs (+5 -5)
📝 tests/SharpCompress.Test/WriterTests.cs (+1 -1)
📝 tests/SharpCompress.Test/Zip/Zip64AsyncTests.cs (+1 -1)
📝 tests/SharpCompress.Test/Zip/ZipReaderAsyncTests.cs (+4 -4)
📝 tests/SharpCompress.Test/packages.lock.json (+242 -68)
➕ tests/SharpCompress.Test/xunit.runner.json (+3 -0)

📄 Description

This properly adds support for ValueTask but this also meant I didn't realize a lot of tests weren't passing.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/adamhathcock/sharpcompress/pull/1136 **Author:** [@adamhathcock](https://github.com/adamhathcock) **Created:** 1/16/2026 **Status:** ✅ Merged **Merged:** 1/16/2026 **Merged by:** [@adamhathcock](https://github.com/adamhathcock) **Base:** `adam/async-creation` ← **Head:** `adam/upgrade-xunit` --- ### 📝 Commits (7) - [`63e124e`](https://github.com/adamhathcock/sharpcompress/commit/63e124e72f2afb379fc42e65fce8dcb14f14d938) Upgrade xunit to v3 - [`75cc368`](https://github.com/adamhathcock/sharpcompress/commit/75cc36849bc3db04479f19f8b1bbaaafff0b7c4a) Initial plan - [`2906529`](https://github.com/adamhathcock/sharpcompress/commit/29065290808e2ffb85e8864fccfbd244b7ad73b9) Fix ReaderFactory.OpenAsyncReader to use async IsArchiveAsync methods - [`e919930`](https://github.com/adamhathcock/sharpcompress/commit/e919930cf6ce1b4e6f96f6f00272c55790c3e6cd) Fix Archive async tests to not use AsyncOnlyStream (archives need seekable streams) - [`c7da19f`](https://github.com/adamhathcock/sharpcompress/commit/c7da19f3a5e0ca103261ce3f1967fe5d08ab3793) Format code with CSharpier - [`0de5c59`](https://github.com/adamhathcock/sharpcompress/commit/0de5c59a77745a3109a70ea58301d3ffe8951bda) Restore AsyncOnlyStream in archive async tests as requested - [`c958d18`](https://github.com/adamhathcock/sharpcompress/commit/c958d184d0d1dea215cc6030662f9c6614c6639b) Merge pull request #1137 from adamhathcock/copilot/sub-pr-1136 ### 📊 Changes **17 files changed** (+297 additions, -108 deletions) <details> <summary>View changed files</summary> 📝 `Directory.Packages.props` (+1 -1) 📝 `src/SharpCompress/Readers/ReaderFactory.cs` (+13 -5) 📝 `tests/SharpCompress.Test/Ace/AceReaderAsyncTests.cs` (+3 -3) 📝 `tests/SharpCompress.Test/Arj/ArjReaderAsyncTests.cs` (+4 -4) 📝 `tests/SharpCompress.Test/GZip/AsyncTests.cs` (+4 -4) 📝 `tests/SharpCompress.Test/GZip/GZipReaderAsyncTests.cs` (+2 -2) 📝 `tests/SharpCompress.Test/ProgressReportTests.cs` (+1 -1) 📝 `tests/SharpCompress.Test/Rar/RarReaderAsyncTests.cs` (+5 -5) 📝 `tests/SharpCompress.Test/ReaderTests.cs` (+1 -1) 📝 `tests/SharpCompress.Test/SharpCompress.Test.csproj` (+3 -2) 📝 `tests/SharpCompress.Test/Tar/TarArchiveAsyncTests.cs` (+4 -1) 📝 `tests/SharpCompress.Test/Tar/TarReaderAsyncTests.cs` (+5 -5) 📝 `tests/SharpCompress.Test/WriterTests.cs` (+1 -1) 📝 `tests/SharpCompress.Test/Zip/Zip64AsyncTests.cs` (+1 -1) 📝 `tests/SharpCompress.Test/Zip/ZipReaderAsyncTests.cs` (+4 -4) 📝 `tests/SharpCompress.Test/packages.lock.json` (+242 -68) ➕ `tests/SharpCompress.Test/xunit.runner.json` (+3 -0) </details> ### 📄 Description This properly adds support for ValueTask but this also meant I didn't realize a lot of tests weren't passing. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-29 22:21:11 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
feedback requested
not bug
pull-request
Mirrored from GitHub Pull Request
 question
up for grabs
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/sharpcompress#1572
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?